This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add flow test fixtures and tests#13986
Merged
fluttergithubbot merged 15 commits intomasterfrom Dec 3, 2019
Merged
Conversation
9512cf8 to
d0b8d9d
Compare
chinmaygarde
approved these changes
Nov 23, 2019
Contributor
chinmaygarde
left a comment
There was a problem hiding this comment.
Primary review in #13949.
385e637 to
e61a611
Compare
liyuqian
reviewed
Nov 26, 2019
Contributor
liyuqian
left a comment
There was a problem hiding this comment.
Finally finished reviewing 1 commit :) Looks good! Left some nit comments.
86b47b6 to
0dce780
Compare
arbreng
commented
Nov 27, 2019
arbreng
commented
Nov 27, 2019
liyuqian
reviewed
Nov 27, 2019
adec981 to
bfec613
Compare
liyuqian
approved these changes
Nov 28, 2019
Contributor
liyuqian
left a comment
There was a problem hiding this comment.
LGTM modulo two missing TODO()s, and a curious question about the ThreadHost change.
5a2488d to
054632a
Compare
054632a to
976abbb
Compare
976abbb to
6156ebb
Compare
6156ebb to
8b3c264
Compare
8b3c264 to
d4d1206
Compare
liyuqian
added a commit
to liyuqian/engine
that referenced
this pull request
Dec 3, 2019
This reverts commit 620f528.
liyuqian
added a commit
that referenced
this pull request
Dec 3, 2019
This was referenced Dec 3, 2019
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
* Revert "Add flow test fixtures and tests (flutter#13986)" This reverts commit 620f528. * Revert "Dynamically determine whether to use offscreen surface based on need (flutter#13976)" This reverts commit a86ef94.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use a MockCanvas to enable unit-testing the flow code without interacting with the GPU.
These tests compile and pass on all platforms, including Fuchsia.
Test: Ran workstation on Fuchsia; ran flow_unittests
Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/list/23711
Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/list/24163