This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Add flow test fixtures and tests#13949
Closed
arbreng wants to merge 1 commit intoflutter:masterfrom
arbreng:flow-unittests
Closed
[fuchsia] Add flow test fixtures and tests#13949arbreng wants to merge 1 commit intoflutter:masterfrom arbreng:flow-unittests
arbreng wants to merge 1 commit intoflutter:masterfrom
arbreng:flow-unittests
Conversation
Contributor
chinmaygarde
left a comment
There was a problem hiding this comment.
This is awesome. We appreciate it. All my comments are nits or minor construction issues.
Contributor
Author
|
This PR has a loooot of logical changes inside. Abandonging in favor of 13986 which is more granular and addresses all feedback here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use a MockCanvas to enable unit-testing the flow code without interacting with the GPU.
These tests compile and pass on all platforms, including Fuchsia.
Test: Ran workstation on Fuchsia; ran flow_unittests
Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/list/23711
Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/list/24163