Fix the unnecessary stringify of Uint8Array contents during zip profile extraction#6004
Merged
canova merged 2 commits intofirefox-devtools:mainfrom May 7, 2026
Merged
Conversation
`String(arbitraryFormat)` was meant to detect ArrayBuffers from different realms, but when the input is already a Uint8Array, it serializes all byte values as a comma-separated string, which allocates hundreds of megabytes for large profiles. Switch to `Object.prototype.toString.call` which returns the correct `[object ArrayBuffer]` tag cross-realm without touching the array contents.
This is not strictly necessary after we changed the `String()` inside `unserializeProfileOfArbitraryFormat`. But this is more correct, so it's better to keep change it.
1e293f9 to
5783a76
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6004 +/- ##
=======================================
Coverage 83.81% 83.82%
=======================================
Files 328 328
Lines 34255 34254 -1
Branches 9572 9572
=======================================
Hits 28712 28712
+ Misses 5115 5114 -1
Partials 428 428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
canova
added a commit
that referenced
this pull request
May 7, 2026
Changes: [Markus Stange] Use custom splitter component (#4606) [fatadel] Fix Download button text color when clicked (#5985) [Samuel Glauser] Fix fullscreen icon size in bottom box (#5987) [Nazım Can Altınova] Add `profiler-cli` for querying profiles (#5963) [Nazım Can Altınova] Bump profiler cli version to 0.1.0 (#5996) [Markus Stange] Switch from max-height to maxHeight in JSX style={{...}}. (#5990) [carverdamien] Fix comment about how time and duration are stored (#5997) [Nazım Can Altınova] Do not show console error when libnames are failed to parse as a URL (#5993) [Nazım Can Altınova] Fix the unnecessary stringify of Uint8Array contents during zip profile extraction (#6004) And special thanks to our localizers: en-CA: chutten en-CA: Saurabh en-GB: Ian Neal es-CL: ravmn fy-NL: Fjoerfoks ia: Melo46 nl: Mark Heijl ru: Valery Ledovskoy sv-SE: Andreas Pettersson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6001.
See my analysis here for more context: #6001 (comment)
Example profile: before / after