Fix fullscreen icon size in bottom box#5987
Merged
canova merged 4 commits intoMay 4, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5987 +/- ##
=======================================
Coverage 85.34% 85.34%
=======================================
Files 318 318
Lines 31922 31922
Branches 8834 8836 +2
=======================================
Hits 27244 27244
Misses 4246 4246
Partials 432 432 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks @rabbitglauser for the PR! It looks better to me compared to the previous version. But I still see that it's a bit bigger than the other icons that we have. Could you make it a bit smaller still? 
(I added the deploy preview to the PR message so we can see it easily) |
Contributor
Author
|
Thanks for the feedback @canova ! I reduced the fullscreen icon size. It now looks visually closer to the surrounding icons in the bottom toolbar. 
|
Merged
canova
added a commit
that referenced
this pull request
May 7, 2026
Changes: [Markus Stange] Use custom splitter component (#4606) [fatadel] Fix Download button text color when clicked (#5985) [Samuel Glauser] Fix fullscreen icon size in bottom box (#5987) [Nazım Can Altınova] Add `profiler-cli` for querying profiles (#5963) [Nazım Can Altınova] Bump profiler cli version to 0.1.0 (#5996) [Markus Stange] Switch from max-height to maxHeight in JSX style={{...}}. (#5990) [carverdamien] Fix comment about how time and duration are stored (#5997) [Nazım Can Altınova] Do not show console error when libnames are failed to parse as a URL (#5993) [Nazım Can Altınova] Fix the unnecessary stringify of Uint8Array contents during zip profile extraction (#6004) And special thanks to our localizers: en-CA: chutten en-CA: Saurabh en-GB: Ian Neal es-CL: ravmn fy-NL: Fjoerfoks ia: Melo46 nl: Mark Heijl ru: Valery Ledovskoy sv-SE: Andreas Pettersson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5984
Summary
This PR adjusts the visual size of the full-screen icon in the bottom source/assembly view.
The full-screen icon appeared slightly larger than the nearby close button, even though the buttons are intended to have similar visual sizing. This change sets a specific
background-sizefor the fullscreen show/hide icons only.Changes
background-size: 14px 14px;for:.bottom-fullscreen-show-button.bottom-fullscreen-hide-buttonTesting
Tested locally with the example profile from the issue and confirmed that the fullscreen icon now appears visually closer in size to the close button.
Deploy preview