Fix that clicking an empty area of the timeline should not switch the…#4416
Merged
Merged
Conversation
… selected panel to the call tree Fixes firefox-devtools#4415
julienw
commented
Jan 10, 2023
| expect(getCallNodePath()).toEqual([]); | ||
| }); | ||
|
|
||
| it('when clicking a stack, this selects the call tree panel', function () { |
Contributor
Author
There was a problem hiding this comment.
In #4331 I said that I couldn't find existing tests for the activity graph, looks like I found them in this file after all... so I moved the existing test here and added a new one.
Codecov ReportBase: 88.56% // Head: 88.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4416 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 282 282
Lines 25493 25494 +1
Branches 6865 6866 +1
=======================================
+ Hits 22577 22578 +1
Misses 2709 2709
Partials 207 207
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… selected panel to the call tree
Fixes #4415
production
deploy preview
STR: