Conversation
❌ Integration test FAILEDRequested by @dconeybe on commit fdf6ffe
Add flaky tests to go/fpl-cpp-flake-tracker |
dconeybe
added a commit
that referenced
this pull request
Dec 17, 2021
…udes to app/src/include/firebase/internal/mutex.h This commit will be deleted once this is rebased onto main.
jonsimantov
approved these changes
Dec 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete
app/src/mutex.h, which, in #792, was converted to just an empty shell that points toapp/src/include/firebase/internal/mutex.h, and adjust all instances where it was included to point to the new location.This is the third PR (the previous ones being #751 and #792) towards moving
firebase::Mutexinto the public-internal includes directory, so that it can be used byfuture.h. See #747 for the rationale.Googlers can see b/206520921 for more details.