Merged
Conversation
dconeybe
commented
Nov 16, 2021
❌ Integration test FAILEDRequested by @dconeybe on commit 428e197
Add flaky tests to go/fpl-cpp-flake-tracker |
jonsimantov
previously approved these changes
Dec 13, 2021
| (void)ret; | ||
| #endif // !FIREBASE_PLATFORM_WINDOWS | ||
| } | ||
| void Acquire(); |
Contributor
There was a problem hiding this comment.
LGTM but maybe add a short comment above each one as long as we're in here.
…uitive to read without having to mentally apply the negation
🍞 Dismissed stale approval on external PR.
Contributor
Author
|
@jonsimantov Could I bother you for another approval? Your last approval got lost when I uploaded new changes. |
jonsimantov
approved these changes
Dec 14, 2021
This was referenced Dec 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move (most of) the implementation of
firebase::Mutexinto.ccfiles from being entirely in themutex.hfile.This is the first PR towards moving
firebase::Mutexinto the public-internal includes directory, so that it can be used byfuture.h. See #747 for the rationale.By splitting the implementation into
.ccfiles it removes the need to pull other headers, likeapp/src/assert.handapp/src/log.halso into the public-internal headers folder.Googlers can see b/206520921 for more details.