Feature/admob 2021 merge from main 2#787
Merged
jonsimantov merged 18 commits intofeature/admob_2021from Dec 4, 2021
Merged
Conversation
* Add Analytics header update to iOS SDK update.
### Android - com.google.firebase.firebase_database → 20.0.3 - com.google.firebase.firebase_perf → 20.0.4 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1527401903). Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com>
* Change Xcode version from 12.2 to 12.4 to ensure GitHub support. * Fix integration tests workflow to respect xcode_version in matrix.
* Update iOS dependencies - Thu Dec 02 2021 ### iOS - Firebase/Analytics → 8.10.0 - Firebase/Auth → 8.10.0 - Firebase/Core → 8.10.0 - Firebase/Crashlytics → 8.10.0 - Firebase/Database → 8.10.0 - Firebase/DynamicLinks → 8.10.0 - Firebase/Firestore → 8.10.0 - Firebase/Functions → 8.10.0 - Firebase/Installations → 8.10.0 - Firebase/Messaging → 8.10.0 - Firebase/RemoteConfig → 8.10.0 - Firebase/Storage → 8.10.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1528664697). * Add missing copyright lines. * Add Firestore release note. Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com> Co-authored-by: Jon Simantov <jsimantov@google.com>
* Properly convert milliseconds to seconds Currently, a value expressed in milliseconds is directly assigned to a variable which is supposed to store seconds and it's later converted to mills again. Thus, convert properly upon assignment * Update readme.md
* Change LogDebug to NSLog. * Change log message. * Add comment.
…780) * Add copyright line to iOS headers * Make copyright conditional to whether the file already has one.
❌ Integration test FAILEDRequested by @jonsimantov on commit f11ef67
Add flaky tests to go/fpl-cpp-flake-tracker |
DellaBitta
approved these changes
Dec 3, 2021
Contributor
Author
|
@DellaBitta the AdMob test failures are expected? |
| void NSArrayOfNSStringToVectorOfString(NSArray* array, | ||
| std::vector<std::string>* string_vector); | ||
| void NSArrayOfNSStringToVectorOfString(NSArray *array, | ||
| std::vector<std::string> *string_vector); |
There was a problem hiding this comment.
Add #include <vector> for vector<>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge main.
Testing
Run integration tests + packaging workflows.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.