Skip to content

Timeout & retry "install integration test deps" step#785

Merged
sunmou99 merged 2 commits intomainfrom
feature/ci-retry
Dec 3, 2021
Merged

Timeout & retry "install integration test deps" step#785
sunmou99 merged 2 commits intomainfrom
feature/ci-retry

Conversation

@sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Dec 2, 2021

Description

Install deps step can be flaky and break the build. e.g.
Add timeout & retry

Testing

See the comment section

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@google-cla google-cla bot added the cla: yes label Dec 2, 2021
@sunmou99 sunmou99 added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Dec 2, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Dec 2, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @sunmou99 on commit f6ad97a
Last updated: Thu Dec 2 21:01 PST 2021
View integration test log & download artifacts

Failures Configs
analytics [TEST] [ERROR] [iOS] [macos] [ios_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov
Copy link
Contributor

jonsimantov commented Dec 2, 2021 •
edited
Loading

I don't think this is the only issue - the Cache NDK step failed, which caused it to try to download the NDK into a partially-filled out directory. I think we also need to ensure that the NDK is unzipped with -o so it doesn't prompt overwriting files. (I pushed a commit to do this.)

@sunmou99
Copy link
Contributor Author

sunmou99 commented Dec 2, 2021

I don't think this is the only issue - the Cache NDK step failed, which caused it to try to download the NDK into a partially-filled out directory. I think we also need to ensure that the NDK is unzipped with -o so it doesn't prompt overwriting files. (I pushed a commit to do this.)

Yes, you are right. And thanks for your fixing commit.

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 3, 2021
@sunmou99 sunmou99 enabled auto-merge (squash) December 3, 2021 01:17
@sunmou99 sunmou99 added skip-release-notes Skip release notes check and removed tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Dec 3, 2021
@sunmou99 sunmou99 merged commit f6ad97a into main Dec 3, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Dec 3, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 3, 2021
jonsimantov added a commit that referenced this pull request Dec 4, 2021
@jonsimantov @sunmou99
@firebase-workflow-trigger @pawelsnk
Feature/admob 2021 merge from main 2 (#787)
f11ef67 
* Fix link in readme (#768)

* update test devices (#757)

* Timeout and Retry FTL failures and mark flakiness

* Update C++ SDK version to 8.8.0.

* Add Analytics header update to iOS SDK update. (#775)

* Add Analytics header update to iOS SDK update.

* Update Android dependencies - Wed Dec 01 2021 (#773)

### Android

- com.google.firebase.firebase_database → 20.0.3
- com.google.firebase.firebase_perf → 20.0.4

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1527401903).

Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com>

* Fix typo in log output.

* Change Xcode version from 12.2 to 12.4 to ensure GitHub support. (#774)

* Change Xcode version from 12.2 to 12.4 to ensure GitHub support.

* Fix integration tests workflow to respect xcode_version in matrix.

* Add extra newline to header comment.

* Update iOS dependencies - Thu Dec 02 2021 (#779)

* Update iOS dependencies - Thu Dec 02 2021

### iOS

- Firebase/Analytics → 8.10.0
- Firebase/Auth → 8.10.0
- Firebase/Core → 8.10.0
- Firebase/Crashlytics → 8.10.0
- Firebase/Database → 8.10.0
- Firebase/DynamicLinks → 8.10.0
- Firebase/Firestore → 8.10.0
- Firebase/Functions → 8.10.0
- Firebase/Installations → 8.10.0
- Firebase/Messaging → 8.10.0
- Firebase/RemoteConfig → 8.10.0
- Firebase/Storage → 8.10.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1528664697).

* Add missing copyright lines.

* Add Firestore release note.

Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com>
Co-authored-by: Jon Simantov <jsimantov@google.com>

* Properly convert milliseconds to seconds (#767)

* Properly convert milliseconds to seconds

Currently, a value expressed in milliseconds is directly assigned to a variable
which is supposed to store seconds and it's later converted to mills again.
Thus, convert properly upon assignment

* Update readme.md

* Change LogDebug to NSLog in app's swizzling code. (#783)

* Change LogDebug to NSLog.

* Change log message.

* Add comment.

* Add copyright line when importing Analytics iOS headers, if missing (#780)

* Add copyright line to iOS headers

* Make copyright conditional to whether the file already has one.

* Also set Xcode version explicitly in Android workflow. (#786)

* Timeout & retry "install integration test deps" step (#785)

* Format code.

Co-authored-by: Борис Рязанцев <88411548+borisssoft@users.noreply.github.com>
Co-authored-by: Mou Sun <69009538+sunmou99@users.noreply.github.com>
Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com>
Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com>
Co-authored-by: pawelsnk <pawelsnk@o2.pl>
@sunmou99 sunmou99 deleted the feature/ci-retry branch December 7, 2021 00:22
@firebase firebase locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cynthiajoan cynthiajoan Awaiting requested review from cynthiajoan

1 more reviewer

@jonsimantov jonsimantov jonsimantov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sunmou99 @jonsimantov

Comments