Skip to content

fix: install dev deps so eslint gets installed#1330

Closed
coopernetes wants to merge 2 commits intomainfrom
fix/ci-lint
Closed

fix: install dev deps so eslint gets installed#1330
coopernetes wants to merge 2 commits intomainfrom
fix/ci-lint

Conversation

@coopernetes
Copy link
Copy Markdown
Contributor

@coopernetes coopernetes commented Dec 15, 2025

Regression from #1315 , eslint isn't getting installed properly since its a dev dependency and we're now running npm ci as part of the build jobs.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 15, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 9727cc0
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69406c7d0f52e6000704f0d4

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 15, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added the fix label Dec 15, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.65%. Comparing base (73b4831) to head (9727cc0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1330   +/-   ##
=======================================
  Coverage   80.65%   80.65%           
=======================================
  Files          65       65           
  Lines        4575     4575           
  Branches      774      774           
=======================================
  Hits         3690     3690           
  Misses        870      870           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coopernetes
Copy link
Copy Markdown
Contributor Author

@jescalada @kriswest unless there's objections, I'm just going to merge this straight in.

@coopernetes
Copy link
Copy Markdown
Contributor Author

coopernetes commented Dec 15, 2025

Doesn't seem to be necessary. Not sure why this workflow run failed.

@kriswest
Copy link
Copy Markdown
Contributor

It is weird - wildly different numbers on deps installation:

failed run:

added 506 packages, and audited 508 packages in 15s

83 packages are looking for funding
run npm fund for details

2 vulnerabilities (1 low, 1 moderate)

working run:

added 1174 packages, and audited 1176 packages in 33s

267 packages are looking for funding
run npm fund for details

1 high severity vulnerability

The workflow ran on head b453f60 - I don't see that in the PR currently. Did it run during a rebase or something? Perhaps a temporarily broken package-lock.json?

@kriswest
Copy link
Copy Markdown
Contributor

P.S. CI tasks should probably use npm ci rather than npm install for predictable results (whiich you were fixing). It looks like this is the only job that doesn't do that. As its linting it doesn't matter a whole lot I suppose.

@coopernetes coopernetes deleted the fix/ci-lint branch January 20, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants