fix: install dev deps so eslint gets installed#1330
fix: install dev deps so eslint gets installed#1330coopernetes wants to merge 2 commits intomainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1330 +/- ##
=======================================
Coverage 80.65% 80.65%
=======================================
Files 65 65
Lines 4575 4575
Branches 774 774
=======================================
Hits 3690 3690
Misses 870 870
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jescalada @kriswest unless there's objections, I'm just going to merge this straight in. |
e59133c to
cd90814
Compare
cd90814 to
f0a8103
Compare
|
Doesn't seem to be necessary. Not sure why this workflow run failed. |
|
It is weird - wildly different numbers on deps installation: failed run:
working run:
The workflow ran on head b453f60 - I don't see that in the PR currently. Did it run during a rebase or something? Perhaps a temporarily broken package-lock.json? |
|
P.S. CI tasks should probably use |
Regression from #1315 ,
eslintisn't getting installed properly since its a dev dependency and we're now runningnpm cias part of the build jobs.