chore: upgrade node & mongo versions in ci, actions upgrades#1315
chore: upgrade node & mongo versions in ci, actions upgrades#1315coopernetes merged 8 commits intomainfrom
Conversation
coopernetes
commented
Dec 9, 2025
- add newer Node versions to build in CI so we test against all major LTS versions
- do the same for mongodb versions; CI is building against an ancient, long EOL version (4.4, Mongo is on version 8.x).
- used ratchet to upgrade actions to their latest versions
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency ReviewThe following issues were found:
|
88fef8e to
2adefde
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1315 +/- ##
=======================================
Coverage 80.64% 80.64%
=======================================
Files 65 65
Lines 4572 4572
Branches 776 776
=======================================
Hits 3687 3687
Misses 870 870
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3c62012 to
9989a4d
Compare
08d755b to
5e3ad88
Compare
5e3ad88 to
ce55423
Compare
Fixes CI error due to CODEQL_ACTION_VERSION mismatch (set to 4.31.7 in codeql v3.31.7)
|
The CI was erroring out because CodeQL had a mismatched parameter internally ( I fixed it by bumping the action to 4.31.7 - this should cover us when v3 gets deprecated next year. |
There was a problem hiding this comment.
@coopernetes LGTM, just wondering if the CodeQL action bump to v4 is appropriate here or if we have a reason to stay at v3. I think ratchet might've set it to 3.31.7 because it's the "Latest" on the codeql-action GH releases page.
|
@coopernetes It seems we need to remove/update the check for "build (20.x, 4.4)" in order to merge the PR. Wonder if this can only be edited by repo admins, as I don't see it in the settings. 🤔 |
Fixed.
Yep - we'll need to tag the finos admin folks to update the check for us. Let me experiment with a "wrapper" or "result" job that can report the result of all the matrix jobs in one shot. Then, when we upgrade language support in the future or change versions, we do not need to modify our CI check. |
3b1b555 to
381ae9d
Compare
381ae9d to
b69447b
Compare
|
@finos-admin can we get a hand to update our branch protection required check rule? Please change it from: This new job runs a script which checks the results of the matrix jobs for each version combination. The result job isn't version specific and will remove the need to update the protection rule next time we add a new version to support in CI. EDIT: Also sent a quick email to help@finos.org |
|
@coopernetes the branch protection rule has been updated. The |