Skip to content

chore: upgrade node & mongo versions in ci, actions upgrades#1315

Merged
coopernetes merged 8 commits intomainfrom
chore/node-upgrades
Dec 15, 2025
Merged

chore: upgrade node & mongo versions in ci, actions upgrades#1315
coopernetes merged 8 commits intomainfrom
chore/node-upgrades

Conversation

@coopernetes
Copy link
Copy Markdown
Contributor

  • add newer Node versions to build in CI so we test against all major LTS versions
  • do the same for mongodb versions; CI is building against an ancient, long EOL version (4.4, Mongo is on version 8.x).
  • used ratchet to upgrade actions to their latest versions

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 9, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 0509d78
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69401ae3b23fe2000908e8f8

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2025

Dependency Review

The following issues were found:

  • ✅ 0 vulnerable package(s)
  • ❌ 1 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.

View full job summary

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.64%. Comparing base (e767463) to head (0509d78).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1315   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files          65       65           
  Lines        4572     4572           
  Branches      776      776           
=======================================
  Hits         3687     3687           
  Misses        870      870           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coopernetes coopernetes force-pushed the chore/node-upgrades branch 3 times, most recently from 3c62012 to 9989a4d Compare December 9, 2025 18:16
@coopernetes coopernetes marked this pull request as ready for review December 9, 2025 18:23
@coopernetes coopernetes force-pushed the chore/node-upgrades branch 2 times, most recently from 08d755b to 5e3ad88 Compare December 9, 2025 18:29
Fixes CI error due to CODEQL_ACTION_VERSION mismatch (set to 4.31.7 in codeql v3.31.7)
@jescalada
Copy link
Copy Markdown
Contributor

The CI was erroring out because CodeQL had a mismatched parameter internally (CODEQL_ACTION_VERSION: 4.31.7 despite the action version being 3.31.7).

I fixed it by bumping the action to 4.31.7 - this should cover us when v3 gets deprecated next year.

Copy link
Copy Markdown
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coopernetes LGTM, just wondering if the CodeQL action bump to v4 is appropriate here or if we have a reason to stay at v3. I think ratchet might've set it to 3.31.7 because it's the "Latest" on the codeql-action GH releases page.

@jescalada jescalada enabled auto-merge December 13, 2025 13:26
@jescalada jescalada disabled auto-merge December 13, 2025 14:14
@jescalada
Copy link
Copy Markdown
Contributor

@coopernetes It seems we need to remove/update the check for "build (20.x, 4.4)" in order to merge the PR. Wonder if this can only be edited by repo admins, as I don't see it in the settings. 🤔

@coopernetes
Copy link
Copy Markdown
Contributor Author

coopernetes commented Dec 13, 2025

@coopernetes LGTM, just wondering if the CodeQL action bump to v4 is appropriate here or if we have a reason to stay at v3. I think ratchet might've set it to 3.31.7 because it's the "Latest" on the codeql-action GH releases page.

Fixed.

@coopernetes It seems we need to remove/update the check for "build (20.x, 4.4)" in order to merge the PR. Wonder if this can only be edited by repo admins, as I don't see it in the settings. 🤔

Yep - we'll need to tag the finos admin folks to update the check for us.

Let me experiment with a "wrapper" or "result" job that can report the result of all the matrix jobs in one shot. Then, when we upgrade language support in the future or change versions, we do not need to modify our CI check.

See https://github.com/orgs/community/discussions/26822

@coopernetes coopernetes force-pushed the chore/node-upgrades branch 3 times, most recently from 3b1b555 to 381ae9d Compare December 13, 2025 16:25
@coopernetes
Copy link
Copy Markdown
Contributor Author

coopernetes commented Dec 13, 2025

@finos-admin can we get a hand to update our branch protection required check rule? Please change it from: build (20.x, 4.4) to build result.

This new job runs a script which checks the results of the matrix jobs for each version combination. The result job isn't version specific and will remove the need to update the protection rule next time we add a new version to support in CI.

EDIT: Also sent a quick email to help@finos.org

@finos-admin
Copy link
Copy Markdown
Member

@coopernetes the branch protection rule has been updated. The build (20.x, 4.4) check has been removed and replaced by build result.

@coopernetes coopernetes merged commit c8b2693 into main Dec 15, 2025
22 of 23 checks passed
@coopernetes coopernetes deleted the chore/node-upgrades branch January 20, 2026 05:59
@jescalada jescalada mentioned this pull request Mar 14, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants