Update from original Master #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the rewrite, changing the port was supported; however, the seleniumPort flag was not added to the cli. closes #360
- override the default variable with the npmrc value - if a flag is set, then use the value - implement a provider class to extend from closes #189
- clean up - move int and proxy test to async / await. closes #359
…#368) Experimental feature to download the chromium browser based on the ChromeDriver version. This might be help to prevent browser / browser driver mismatch when downloading ChromeDriver. In the new scenario, you could download ChromeDriver 73.x.x.x and Chromium 73.
- Do a version match based on string startsWith of the maxVersion An example: Matching "0.1" might find versions 0.14.0, 0.151.0, 0.1.0. It will then get the max version which is 0.151. If a user wanted to get 0.1, then they could specify version "0.1." - Added a unit test to the version_list to find max versions. - Fix / update interchangable aliases: - selenium == standalone - chromedriver == chrome - geckodriver == gecko - iedriver = ie Tagging #280, #358, #353. Additional work is still required to have a config file that has this information instead of hard coding it.
…nager (#372) - During the static call (for 5.4.2 to built/lib/config) to getSeleniumDir, construct the update-config.json. This is just combining existing information from geckodriver.config.json, chrome.config.json and selenium-server.config.json. Important note that since this is just added in, this file will not be removed during the clean up and will always be overwritten when making the static call. If it is called 3 times in the driverProviders/local test, it will rewrite the file 3 times. - Add test for Protractor. For both version 5.4.2 and version 6+ calls to webdriver-manager. - Add jasmine protractor test to circle ci test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.