feat(max_versions): set max versions based on string matching #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
DO NOT MERGE yet. Need to pass the test and write a unit test. |
ee4a03d to
69c0450
Compare
16ca7f3 to
bef4e3f
Compare
heathkit
approved these changes
Apr 25, 2019
- Do a version match based on string startsWith of the maxVersion An example: Matching "0.1" might find versions 0.14.0, 0.151.0, 0.1.0. It will then get the max version which is 0.151. If a user wanted to get 0.1, then they could specify version "0.1." - Added a unit test to the version_list to find max versions. - Fix / update interchangable aliases: - selenium == standalone - chromedriver == chrome - geckodriver == gecko - iedriver = ie Tagging angular#280, angular#358, angular#353. Additional work is still required to have a config file that has this information instead of hard coding it.
This was referenced Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a version match based on string startsWith of the maxVersion
An example:
Matching "0.1" might find versions 0.14.0, 0.151.0, 0.1.0. It will then
get the max version which is 0.151. If a user wanted to get 0.1, then
they could specify version "0.1."
Fix / update interchangable aliases:
Tagging #280, #358, #353. Additional work is still required to have a
config file that has this information instead of hard coding it.