Add support all lifecycle methods to ShallowRender#7912
Closed
koba04 wants to merge 1 commit intofacebook:masterfrom
Closed
Add support all lifecycle methods to ShallowRender#7912koba04 wants to merge 1 commit intofacebook:masterfrom
koba04 wants to merge 1 commit intofacebook:masterfrom
Conversation
Contributor
Author
|
Enzyme is supporting all lifecycle methods in The implementation has some dirty hacks. I think it would be nice If this PR is merged, I can remove it. |
Contributor
Author
|
@spicyj Could you review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has a breaking change.
Supporting all lifecycle methods in ShallowRender merged at #4993, but reverted at #5394.
The reason why the PR is reverted is that it didn't support string
refs.This PR is fixed it.
Currently, ShallowRender is replacing
_renderValidatedComponentwith_renderValidatedComponentWithoutOwnerOrContext, which it seems to be a little hacky.I think it's better to assign
nullto_onwerfiled.