Revert #4993 with an added test for refs#5394
Merged
sophiebits merged 1 commit intofacebook:masterfrom Nov 5, 2015
Merged
Conversation
Member
|
But the new test fails? |
We were shallow-rendering a component that used refs at FB so this can't go in as-is. It's a little unclear what we _should_ do though, since there is nothing to hold a ref to (since we're shallowly rendering) and we generally promise that child refs are resolved before a parent's componentDidMount. Also, changing shallow rendering to use the original `_renderValidatedComponent` (instead of `_renderValidatedComponentWithoutOwnerOrContext`) breaks tests because now the `_owner` field doesn't match up for `toEqual` (non-null in `getRenderOutput` but null if constructed in a test).
10d614a to
9419976
Compare
Collaborator
Author
|
Oops, I screwed up the change. That's what tests are for. Fixed. |
Member
|
Diffing is too smart so it's hard to tell that it was a clean revert with just a new test below… If only there was some way to clearly separate changes into 2 distinct operations 😛 |
Collaborator
Author
|
Well I had to patch the original PR because of a conflict so it would've been two commits to revert anyway. |
sophiebits
added a commit
that referenced
this pull request
Nov 5, 2015
Revert #4993 with an added test for refs
Contributor
|
@spicyj updated the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were shallow-rendering a component that used refs at FB so this can't go in as-is. It's a little unclear what we should do though, since there is nothing to hold a ref to (since we're shallowly rendering) and we generally promise that child refs are resolved before a parent's componentDidMount. Also, changing shallow rendering to use the original
_renderValidatedComponent(instead of_renderValidatedComponentWithoutOwnerOrContext) breaks tests because now the_ownerfield doesn't match up fortoEqual(non-null ingetRenderOutputbut null if constructed in a test).