Merged
Conversation
$TRAVIS_COMMIT_RANGE was broken but it seems what we're doing is worse and resulting in false negatives. The result of the bad range was that we weren't running lint or tests for things we should have been. It actually looks like $TRAVIS_COMMIT has been wrong and it's not clear why this has been working at all.
Member
Author
|
For some more details: #3349 should have failed on Travis due to lint errors but it didn't. Looking at the travis results it showed that we were checking an invalid commit range. The start commit was right but the end commit was not, which is So the commit that was in It might be that when a PR doesn't merge cleanly that commit doesn't exist. It's really not clear though. But it seems like the already defined |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We aren't triggering testing / lint for some PRs that we should...