Fix #1790. Disabled input still clickable in IE11.#3349
Fix #1790. Disabled input still clickable in IE11.#3349nhunzaker wants to merge 1 commit intofacebook:masterfrom
Conversation
There was a problem hiding this comment.
Perhaps this comment should be updated as well?
There was a problem hiding this comment.
This comment does feel superfluous, with the comment at:
https://github.com/facebook/react/pull/3349/files#diff-7697f9038a7012efcea5287199198866R30
There was a problem hiding this comment.
It may be useful to pull that comment out of filterDisabledEvents and place it where the Clone this.props comment existed.
There was a problem hiding this comment.
We don't need to do this right? (and we can remove mouseListenerNames)
There was a problem hiding this comment.
Correct. I missed this when I transposed over from my dead fork :-/. Good catch!
7290075 to
a8714c6
Compare
|
Can you make sure you sure fix all the lint errors (warnings are allowed but errors will cause travis to fail as you can see happening). You can test that locally with |
Takes some code from ReactDOMButton in order to solve the same problem within ReactDOMInput, ReactDOMSelect, and ReactDOMTextarea.
|
@zpao Amended. It's like it never happened! |
|
Closing this in favor of #6215 |
This PR is a resubmit of #1820. It updates the branch and addresses my folly with deleting the fork.
As a reminder:
Takes some code from ReactDOMButton in order to solve the same problem within ReactDOMInput, ReactDOMSelect, and ReactDOMTextarea.
Fixes #1790