Skip to content

Make ReactSwipeRefreshLayout extendable #55192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Abbondanzo wants to merge 2 commits into from
Closed

Make ReactSwipeRefreshLayout extendable #55192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30f5a70
Always enable nested scrolling for swipe refresh layouts (#55189)
Abbondanzo Jan 15, 2026
2b94a76
Make ReactSwipeRefreshLayout extendable (#55192)
Abbondanzo Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react-native/Libraries/Components/ScrollView/ScrollView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1850,6 +1850,8 @@ class ScrollView extends React.Component<ScrollViewProps, ScrollViewState> {
{style: StyleSheet.compose(baseStyle, outer)},
<NativeScrollView
{...props}
// Nested scroll should always be enabled to allow the child scroll view to handle events before passing them to the refresh control parent
nestedScrollEnabled={props.nestedScrollEnabled ?? true}
style={StyleSheet.compose(baseStyle, inner)}
// $FlowFixMe[incompatible-type] - Flow only knows element refs.
ref={scrollViewRef}>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6022,7 +6022,7 @@ public abstract interface class com/facebook/react/views/scroll/VirtualView {
public abstract fun onModeChange (Lcom/facebook/react/views/virtual/VirtualViewMode;Landroid/graphics/Rect;)V
}

public final class com/facebook/react/views/swiperefresh/ReactSwipeRefreshLayout : androidx/swiperefreshlayout/widget/SwipeRefreshLayout {
public class com/facebook/react/views/swiperefresh/ReactSwipeRefreshLayout : androidx/swiperefreshlayout/widget/SwipeRefreshLayout {
public fun <init> (Lcom/facebook/react/bridge/ReactContext;)V
public fun canChildScrollUp ()Z
public fun dispatchGenericMotionEvent (Landroid/view/MotionEvent;)Z
Expand Down
2 changes: 1 addition & 1 deletion ...actAndroid/src/main/java/com/facebook/react/views/swiperefresh/ReactSwipeRefreshLayout.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import kotlin.math.abs
* pull-to-refresh functionality. It handles touch event interception for the refresh gesture while
* properly forwarding other events to its children.
*/
public class ReactSwipeRefreshLayout(reactContext: ReactContext) :
public open class ReactSwipeRefreshLayout(reactContext: ReactContext) :
SwipeRefreshLayout(reactContext) {

private var didLayout: Boolean = false
Expand Down
Loading