Make ReactSwipeRefreshLayout extendable#55192
Closed
Abbondanzo wants to merge 2 commits intofacebook:mainfrom
Closed
Make ReactSwipeRefreshLayout extendable#55192Abbondanzo wants to merge 2 commits intofacebook:mainfrom
Abbondanzo wants to merge 2 commits intofacebook:mainfrom
Conversation
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90789479. |
) Summary: If nested scrolling is not enabled by default for ScrollView that define a `RefreshControl`, the wrapping Android view `ReactSwipeRefreshLayout` will swallow and discard non-touch scroll actions, like joystick movements. This change updates the default to be true, a more-sane default, which aligns with the existing touch actions that are always allowed. This does not impact touch-based behavior at all. Changelog: [Android][Changed] Updated the `nestedScrollEnabled` prop to default to true if the ScrollView defines a `refreshControl` Differential Revision: D90778643
Summary: Making `ReactSwipeRefreshLayout` open so one can subclass with a custom implementation Changelog: [Internal] Differential Revision: D90789479
2892e84 to
2b94a76
Compare
Collaborator
|
This pull request was successfully merged by @Abbondanzo in ef9bab2 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in ef9bab2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Making
ReactSwipeRefreshLayoutopen so one can subclass with a custom implementationChangelog: [Internal]
Differential Revision: D90789479