Skip to content

Fix JS API breaking change detection to compare against merge base #54819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emily8rown wants to merge 3 commits into from
Closed

Fix JS API breaking change detection to compare against merge base #54819

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c4fbfb
changed the js api breaking changes yaml to compare the pr head again…
emily8rown Dec 8, 2025
40f24b3
add final empty line
emily8rown Dec 9, 2025
c08d82b
Merge branch 'facebook:main' into fix-false-positive-breaking-reactNa…
emily8rown Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions .github/actions/diff-js-api-breaking-changes/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,38 @@ description: Check for breaking changes in the public React Native JS API
runs:
using: composite
steps:
- name: Fetch snapshot from PR head
- name: Checkout PR branch
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}

- name: Get merge base commit with main
id: merge_base
shell: bash
run: |
BASE=$(git merge-base ${{ github.event.pull_request.head.sha }} origin/main)
echo "merge_base=$BASE" >> $GITHUB_OUTPUT

- name: Fetch snapshots from PR head and merge base
shell: bash
env:
SCRATCH_DIR: ${{ runner.temp }}/diff-js-api-breaking-changes
run: |
mkdir $SCRATCH_DIR
git fetch --depth=1 origin ${{ github.event.pull_request.head.sha }}
mkdir -p $SCRATCH_DIR
# Fetch from PR head
git show ${{ github.event.pull_request.head.sha }}:packages/react-native/ReactNativeApi.d.ts > $SCRATCH_DIR/ReactNativeApi-after.d.ts \
|| echo "" > $SCRATCH_DIR/ReactNativeApi.d.ts
|| echo "" > $SCRATCH_DIR/ReactNativeApi-after.d.ts
# Fetch from merge base
git show ${{ steps.merge_base.outputs.merge_base }}:packages/react-native/ReactNativeApi.d.ts > $SCRATCH_DIR/ReactNativeApi-before.d.ts \
|| echo "" > $SCRATCH_DIR/ReactNativeApi-before.d.ts

- name: Run breaking change detection
shell: bash
env:
SCRATCH_DIR: ${{ runner.temp }}/diff-js-api-breaking-changes
run: |
node ./scripts/js-api/diff-api-snapshot \
${{ github.workspace }}/packages/react-native/ReactNativeApi.d.ts \
$SCRATCH_DIR/ReactNativeApi-before.d.ts \
$SCRATCH_DIR/ReactNativeApi-after.d.ts \
> $SCRATCH_DIR/output.json
Loading