Fix JS API breaking change detection to compare against merge base#54819
Closed
emily8rown wants to merge 3 commits intofacebook:mainfrom
Closed
Fix JS API breaking change detection to compare against merge base#54819emily8rown wants to merge 3 commits intofacebook:mainfrom
emily8rown wants to merge 3 commits intofacebook:mainfrom
Conversation
…st the branch base instead of the head of main
huntie
reviewed
Dec 8, 2025
|
@emily8rown merged this pull request in e7f5618. |
Collaborator
|
This pull request was successfully merged by @emily8rown in e7f5618 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
diff-js-api-breaking-changesaction to compare the PR's changes against the merge base (where the branch diverged from main) instead of the current tip of main.Problem
The previous implementation compared the current state of
mainto the PR head. This could produce false positive results when main had new commits to reactNativeApi.d.ts reporting breaking changes from main as if they were introduced by the PR.Solution
origin/mainChangelog:
[GENERAL] [FIXED] - Updates the
diff-js-api-breaking-changesaction to compare the PR's changes against the merge base (where the branch diverged from main) instead of the current tip of main.Test Plan:
(outputs shown for #54815)
Tested locally on branch that previously got false positive:
Mirror old approach:
output:
Mirror new approach:
output: