[Docker] Docker workflow upgrade#197
Open
fchris82 wants to merge 5 commits into
Open
Conversation
- Rename .env to .env.dist - Add host and port support - Update the README.md
9f5179f to
9b99076
Compare
Contributor
|
Hi @fchris82, nice contribution! Things to note:
good point |
Author
|
I have been trying the Launchpad. I like the concept, I wanted to similar :) I'm reviewing and when I miss something, I will make pull request there or jira ticket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is better way when the developer can use custom
.env, and can change eg. theHTTP_HOSTandHTTP_PORT.For example I am using the
8080port by other program and I prefer the unique domain per project because of cookies and remembered usernames/passwords.So I want to use: