EZP-27788: Update and cleanup docker config for Docker 17.06 features#192
Merged
Conversation
4 tasks
93580ef to
8c09f88
Compare
15599d3 to
ce2f7c1
Compare
1 task
0b80a32 to
0c4a548
Compare
added 9 commits
August 18, 2017 15:30
Now that Docker 17.06 stable release is out, `:cached` and other features are now available in stable versions and can be used (17.04/5: edge). Bumps compose version all the way up to 3.3 which came in 17.06 for future use and hopefully not having to bump in in a while.
Should theoretically get rid of the issue where app image starts up
before mariadb is ready for connections, leading to user reaching 500 page.
Note: The previous commit adding cached mounts for the sql file mostly fixes the
issue, but this commit should in theory avoid app contianer starting to early.
Based on code from ezsystems/ezplatform-ee-demo#33
…ust compose files As a bonus this also shorten the paths when working with the files.
… are for Aslo rather add links to Launchpad for people wanting to get up and running easily.
vidarl
reviewed
Aug 21, 2017
Member
vidarl
left a comment
There was a problem hiding this comment.
Looks good, but would appreciate if varnish' malloc setting is injected via environment variable as suggested
|
|
||
| EXPOSE 80 6082 | ||
|
|
||
| CMD ["varnishd", "-F", "-a", ":80", "-T", ":6082", "-f", "/etc/varnish/default.vcl", "-s", "malloc,256M"] |
Member
There was a problem hiding this comment.
Would it not be nice if "256M" would be defined in a variable in .env ?
This is a setting which is typically customized....
Contributor
Author
There was a problem hiding this comment.
true, can try to use env variables in build args.
vidarl
approved these changes
Aug 24, 2017
andrerom
pushed a commit
that referenced
this pull request
Aug 27, 2017
Volume not currently used in prod container, and for cases where there are not css/js/bundle assets amke sure folder is there so build does not break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker 17.06 came out in June, and with it these notable features are now in stable channel which we haven't started using yet:
:cached, partly improving mac/windows performance (as tested in [WIP] Update to use Docker 17.04 for improved performance #173)Todo / TBD
Currently blocked on bug in Docker 17.06 that is solved in 17.06.01-rcfalse poitive during testing, the issue was something else 😕Update doc to refer to launchpad for simple use cases_commited to active branches ahead of 1.11 release in 7f2abb5acd555a0c70a8a5c77c04814be2e3af41_doc/dockerand adapt yml/doc given it is about more then just docker-compose now ( and shorter paths ;) )Possible followups: