Skip to content

Conversation

@AlexeyYukhin
Copy link

Summary

  • esp_eth_phy_new_ksz8081 call issue fixed, which was leading to build process error with error "error: 'esp_eth_phy_new_ksz8081' was not declared in this scope"
  • INADDR_NONE const variable name conflict resolved in IPAdrdress.h module

Impact

This PR will allow other users to easily compile their ESP-IDF projects with arduino as a component

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2021

CLA assistant check
All committers have signed the CLA.

@Jason2866
Copy link
Collaborator

What is different to #5599 ?

@AlexeyYukhin
Copy link
Author

What is different to #5599 ?

didn't see that PR. actually it does the same thing, but why it's still not applied? And also i've added IPAddress fix, there was variable name conflict with define macros

@atanisoft
Copy link
Collaborator

And also i've added IPAddress fix, there was variable name conflict with define macros

By removing that variable you are potentially breaking any projects which depend on it's existence. It is only a name conflict in some circumstances otherwise it would have been changed long ago, usually this would only be seen if you are doing raw socket manipulation in the same file where this is included.

@me-no-dev
Copy link
Member

#5599 is merged. You can not "fix" IPAddress like this :)

@me-no-dev me-no-dev closed this Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants