only use ksz8081 for idf versions later than 4.3 (this fixes compile as component for idf 4.3) #5599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
atanisoft
reviewed
Aug 26, 2021
|
seems to work! compiled on IDF v4.3 without any trouble! |
liebman
commented
Aug 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
esp_eth_phy_new_ksz8081was added in IDF after version 4.3 and generates a compilation error with IDF-4.3. This change will only useesp_eth_phy_new_ksz8081for IDF versions after 4.3Impact
This can now be compiled as a component using IDF-4.3.