Fix/orderservice integration test hang#17
Merged
Conversation
…exercise The Codecov badge reads 18.28% because the previous CI setup only uploaded unit-test coverage. The 58.5% baseline cited in CLAUDE.md / STATUS.md is the *aggregated* number from reportgenerator (unit + integration combined). Two changes to the integration-tests job: 1. Add --collect:"XPlat Code Coverage" to both `dotnet test` steps so Cobertura XML is emitted alongside the TRX results. 2. Add a codecov-action@v5 upload step flagged "integration" so the dashboard can distinguish unit vs integration contributions. Combined with the existing "unit" flag from the build job, the overall % reflects end-to-end coverage. After this lands AND the OrderService integration hang fix from the previous commit takes effect, the badge should read ~58% — the actual exercise level. Until both land, the badge undersells the repo because integration tests can't run to upload their coverage XMLs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…test fix Updates STATUS.md after PR #15 (AI workflow tooling) merged and during the follow-up fix PR for OrderService integration tests: - Adds "Recently landed" bullet for PR #15 — the .claude/ + .github/ tooling buildout (hooks, slash commands, agent, 8 curated community skills, PR template, CodeRabbit, architecture map, Codecov badges). - Adds "Recently landed" bullet for the OrderService integration test fix + the Codecov integration-coverage upload, with both root causes documented for the next person who steps on a similar trap. - Updates "Build / test state": OrderService integration tests now actually verified green locally (4/4 in 16.2s) — they were written 9 days ago in commit 76b2f2f but never observed green in CI until today. - Notes the Codecov 18% → ~58% transition that's expected once both this PR's commits land on main. - Bumps the "Last updated" date. The "architecture is built; most has not been runtime-verified" preamble stays — still true in aggregate (cross-service E2E over real ASB wire is still uncovered, no production perf baselines, AppHost smoke not fully automated). One specific counterexample is now closed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR adds integration test coverage collection to the CI workflow and documents the integration test verification status. The workflow now gathers Cobertura XML output during Catalog and Order integration test runs and uploads it to Codecov with the ChangesIntegration Test Coverage Reporting
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 175: Replace the mutable action tag used in the workflow step that
currently reads "uses: codecov/codecov-action@v5" with an immutable commit SHA;
find the CI workflow step referencing codecov/codecov-action and change the uses
value to the action's pinned commit (e.g.,
codecov/codecov-action@<full-commit-sha> obtained from the action repo) so the
workflow is pinned to a specific immutable release.
In `@docs/STATUS.md`:
- Line 70: The current sentence starting "**Coverage** — Codecov badge currently
18.28% (unit-tests only)..." still says the integration upload is "in-flight";
update that sentence to state the integration-tests Codecov upload is now
configured by this PR and that the badge/aggregate will reflect the new combined
coverage after the next successful CI run, while noting that the badge currently
reflects unit-tests only unless the integration upload has completed and that
the expected aggregate will be ~58% once the integration coverage is processed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 538357b4-2652-4146-8e47-0d8553da8f9b
📒 Files selected for processing (2)
.github/workflows/ci.ymldocs/STATUS.md
| # reportgenerator's aggregation in CLAUDE.md). | ||
| - name: Upload integration coverage to Codecov | ||
| if: ${{ !cancelled() }} | ||
| uses: codecov/codecov-action@v5 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify all GitHub Actions references and identify unpinned ones.
rg -nP '^\s*uses:\s*[^@]+@([A-Za-z0-9_.-]+)\s*$' .github/workflows/*.yml \
| rg -nPv '@[0-9a-fA-F]{40}\b'Repository: emeraldleaf/NextAurora
Length of output: 1289
Pin codecov/codecov-action to an immutable commit SHA
.github/workflows/ci.yml:175 uses the mutable tag codecov/codecov-action@v5, which is a supply-chain risk under action-pinning rules.
Suggested change
- uses: codecov/codecov-action@v5
+ uses: codecov/codecov-action@<FULL_LENGTH_COMMIT_SHA> # v5🧰 Tools
🪛 zizmor (1.25.2)
[error] 175-175: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/ci.yml at line 175, Replace the mutable action tag used in
the workflow step that currently reads "uses: codecov/codecov-action@v5" with an
immutable commit SHA; find the CI workflow step referencing
codecov/codecov-action and change the uses value to the action's pinned commit
(e.g., codecov/codecov-action@<full-commit-sha> obtained from the action repo)
so the workflow is pinned to a specific immutable release.
CodeRabbit's first-pass run flagged: "Validation error: Unrecognized key(s) in object: 'tools'". The block I added in PR #15 was speculative — that schema shape (tools.github-checks.enabled / timeout_ms) is not part of the current .coderabbit.yaml v2 schema. CodeRabbit was silently ignoring it. Also adds the schema annotation `# yaml-language-server: $schema=...` at the top so editors with YAML language-server support get auto-completion + validation feedback on future edits, catching this kind of speculative-shape drift at edit time instead of first-run time. Behavioral change: none. Removing the ignored block changes nothing about how CodeRabbit reviews; per-path instructions and chat auto-reply are intact. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
CodeRabbit (PR #17) flagged that the "in-flight PR" phrasing goes stale the moment this PR merges. Reword to describe the configured state (upload is in ci.yml) and the pending event (badge reflects aggregate after the next green CI run), not the temporal state of this PR. Addresses CodeRabbit finding #2 of 2 on the PR. Finding #1 (pin codecov-action to commit SHA) deferred — would create inconsistency with the other six actions in the same workflow (actions/checkout@v6, actions/setup-dotnet@v5, actions/cache@v5, dorny/test-reporter@v3, github/codeql-action/*@v4, plus the two codecov-action calls), all of which use version-pinned mutable tags by existing repo convention. If we want SHA-pinning, it's a workflow-wide hardening pass, not a one-off here. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
emeraldleaf
added a commit
that referenced
this pull request
May 23, 2026
PR #17 (fix/orderservice-integration-test-hang) merged 2026-05-23 17:56 UTC. The STATUS.md text I added in that PR had forward-looking phrasing ("this PR, in flight", "will reflect ... after the next successful CI run", "CI confirmation pending the fix PR merge") that goes stale the moment the PR lands. Rewording to describe present state: - OrderService integration test bullet: cite the merge (PR #17) and the first-green CI timestamp + per-step durations (Catalog 58s, Order 40s). - Codecov sub-bullet: cite the measured delta (18.28% → 56.14%) instead of the expected aggregate. - Build/test state: drop "Local run / CI pending" duality — both pass now. - Coverage line: state the current badge value, not a future expectation. Also catches one older stale entry: the EF Core review + fixes bullet still said "(this session, uncommitted)" — that work landed in 825d6bd already. Replaced with the commit hash for findability. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Merged
emeraldleaf
added a commit
that referenced
this pull request
May 23, 2026
* docs(dev-loop): inventory all tooling + visual workflow + honest gap analysis Three new files in docs/: - dev-loop.md (markdown inventory) — every tool, hook, agent, skill, and config that shapes how code lands in this repo, organized by *when* in the dev loop it fires (5 stages: Edit-time, Build-time, Test-time, PR-time, Merge/Runtime). For each tool: file path so a reader can verify it actually exists. - dev-loop.svg (visual companion) — the same 5-stage flow as a left-to-right diagram with per-stage tool detail and a dotted-loop arrow showing review iteration. Hand-written SVG (not generated via Playwright — the excalidraw render script hit a 30s+ timeout loading the esm.sh ES module repeatedly in this environment). - dev-loop.excalidraw (editable source) — the highway skeleton in Excalidraw format. Open in Excalidraw web/desktop or the VS Code Excalidraw extension to extend; export as SVG to refresh dev-loop.svg. Gap analysis is the load-bearing part of the doc. Each gap (10 total — cross-service E2E, perf baselines, settings.json cruft, SHA-pinning, coverage gate, smoke-run automation, secret scanning, prod migrations, agent-vs-CodeRabbit overlap, AI-commit-tagging) is paired with a sized pragmatic fix — explicitly not "build a whole new system." The signal this doc tries to send is: knowing when to stop adding tooling is more pragmatic than maximum theoretical coverage. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * docs(status): freshness pass after PR #17 merge PR #17 (fix/orderservice-integration-test-hang) merged 2026-05-23 17:56 UTC. The STATUS.md text I added in that PR had forward-looking phrasing ("this PR, in flight", "will reflect ... after the next successful CI run", "CI confirmation pending the fix PR merge") that goes stale the moment the PR lands. Rewording to describe present state: - OrderService integration test bullet: cite the merge (PR #17) and the first-green CI timestamp + per-step durations (Catalog 58s, Order 40s). - Codecov sub-bullet: cite the measured delta (18.28% → 56.14%) instead of the expected aggregate. - Build/test state: drop "Local run / CI pending" duality — both pass now. - Coverage line: state the current badge value, not a future expectation. Also catches one older stale entry: the EF Core review + fixes bullet still said "(this session, uncommitted)" — that work landed in 825d6bd already. Replaced with the commit hash for findability. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * docs(dev-loop): resolve placeholder [text](#) markdown links CodeRabbit (PR #20) flagged two empty markdown links — perf-baselines.md and codecov.yml — both rendered as [text](#) because the referenced files don't exist yet (they're future-work suggestions in the gap analysis). MD042 (no-empty-links) violation. Fix is dropping the link syntax and calling out parenthetically that the file isn't yet created — keeps the prose readable without producing a clickable "#" link that goes nowhere. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed [required]
How it was built [required]
If AI was involved: link to the conversation transcript or commit messages that describe
the AI workflow (e.g.
gh issue view Nif the conversation is preserved in an issue).Architecture impact [skip if N/A]
NextAurora.Contracts/Events)See CLAUDE.mdparaphraseFor non-trivial architectural changes, consider invoking the
architecture-revieweragentlocally before requesting review.
Verification [required]
dotnet buildclean (zero warnings — TreatWarningsAsErrors is on)dotnet testpasses locallycurl /api/v1/ordersand observed expected response>OrderPlacedEventand watched PaymentService consume it>dotnet run --project NextAurora.AppHostand confirmed all services reach "Running" (not "Finished") in the dashboardDeferred / known gaps [skip if N/A]
Linked docs / issues [skip if N/A]
Summary by CodeRabbit
Chores
Documentation