ci: wire Payment + Shipping integration tests into CI#109
Conversation
The integration-tests job ran only the Catalog (Postgres + Redis) and Order (SQL Server + Wolverine outbox) slices. Payment + Shipping shipped their own integration projects but were never added to ci.yml — so PaymentService.Tests.Integration (SQL Server, outbox-in-non-handler wrap, recovery job) and ShippingService.Tests.Integration (Postgres, IDOR + saga consume-side handlers) ran locally but not in CI. This is the gap that contradicted CLAUDE.md "Testing" — the rule said "CatalogService slice and OrderService slice exist" while STATUS.md claimed "all four services...green in CI." STATUS.md was the aspirational one; CLAUDE.md was the accurate one until now. Adding the two missing steps closes the gap and updates CLAUDE.md's Testing rule to list all four slices + name CI as the place they run. Each slice is its own step so a single-slice failure surfaces by name instead of masking other failures in a bundled run. Runtime cost: ~1-2 min added to the integration-tests job for two more container boots (MsSql + Postgres). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR extends the CI integration test suite by adding Payment and Shipping service tests to the existing pipeline, alongside Catalog and Order service tests. The workflow steps produce standard TRX and coverage artifacts, and testing documentation is updated to describe all four services. ChangesIntegration Test Coverage Expansion
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
After #109 wired Payment + Shipping integration tests into CI, two doc sites still claimed only the Catalog + Order slices existed: - README.md "Verification at every layer" listed only Catalog (Postgres + Redis) and Order (SQL Server + stubbed Wolverine). The "134 unit + integration slices" count had also drifted to 142. - docs/architecture.md "Gaps & Future Work" said "CatalogService and OrderService single-service slices exist" and framed the cross-service gap as the only remaining work. Surfaced by a doc-drift sweep after the /check-rules audit. Changes: - README: list all four slices with their containers; rephrase the test count as "100+ unit + integration tests" instead of a precise number that drifts every PR. - architecture.md: update the slice list to all four; clarify that the remaining gap is wire-level cross-service coverage specifically. No rule changes; pure documentation refresh. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Summary
The `integration-tests` job in ci.yml ran only the Catalog + Order slices. The Payment and Shipping integration projects existed and ran locally but were never added to CI — drift between disk reality and the CI workflow.
Why
What changed
What this proves
Runtime cost
~1-2 min added to the integration-tests job for MsSql + Postgres container boots. Acceptable — the job is parallel with the fast unit job, so wall-clock PR latency is bounded by whichever was already slower.
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Documentation