Standalone purger support#124
Merged
githubzilla merged 6 commits intoeloqdata:eloq-10.6.10from Sep 23, 2025
Merged
Conversation
WalkthroughUpdated two storage/eloq submodule pointers, added two purger source files to the ELOQ RocksDB cloud build, and introduced a RocksDB cloud purger periodicity config in mysql-test. No public API declarations were modified. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant TestHarness as Test Harness / Scheduler
participant MySQL as mysqld (test)
participant Purger as Purger (purger_* files)
participant Store as RocksDB Cloud Store
Note over TestHarness,MySQL: periodic trigger (config = 30s)
TestHarness->>MySQL: start/poll (every 30s)
MySQL->>Purger: invoke purge cycle
Purger->>Store: enumerate expired entries (sliding window)
alt expired entries found
Purger->>Store: delete expired entries
Store-->>Purger: deletion results
else none found
Store-->>Purger: no-op
end
Purger-->>MySQL: report status
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Comment |
xiexiaoy
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit