Skip to content

Standalone purger support#124

Merged
githubzilla merged 6 commits intoeloqdata:eloq-10.6.10from
githubzilla:standalone_purger_support
Sep 23, 2025
Merged

Standalone purger support#124
githubzilla merged 6 commits intoeloqdata:eloq-10.6.10from
githubzilla:standalone_purger_support

Conversation

@githubzilla
Copy link
Collaborator

@githubzilla githubzilla commented Sep 23, 2025

Summary by CodeRabbit

  • Chores
    • Updated internal storage and transaction submodule references for maintenance.
    • Added backend purger components to the datastore build (no user-facing changes).
  • Tests
    • Introduced a purge periodicity configuration in test settings.
  • Notes
    • No changes to public APIs, user workflows, performance guarantees, or required user actions.

@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2025

Walkthrough

Updated two storage/eloq submodule pointers, added two purger source files to the ELOQ RocksDB cloud build, and introduced a RocksDB cloud purger periodicity config in mysql-test. No public API declarations were modified.

Changes

Cohort / File(s) Summary of Changes
Submodule pointer updates
storage/eloq/store_handler, storage/eloq/tx_service
Advanced submodule references (store_handler: e0e4ef07c3a9cab621adc16c4edbf1f8935735db6c5604a002e58aad45dfebd09b51ae150195b330; tx_service: 16f3cf1d6aabb763b1e8d2a71f0b06385a4631e3575b5609f555e4310a5a7a227b90fcac8e1103a7). Metadata-only updates; no code/API changes in this repo.
Build: add purger sources
storage/eloq/CMakeLists.txt
Appended purger_event_listener.cpp and purger_sliding_window.cpp to the ELOQ RocksDB cloud S3 datastore source list (MYELOQ_SOURCES).
Test config: purger periodicity
mysql-test/include/eloq_kv_dss.cnf
Added eloq_dss_rocksdb_cloud_purger_periodicity_secs = 30 under [mysqld] to set purger periodicity for RocksDB cloud DSS in tests.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant TestHarness as Test Harness / Scheduler
  participant MySQL as mysqld (test)
  participant Purger as Purger (purger_* files)
  participant Store as RocksDB Cloud Store

  Note over TestHarness,MySQL: periodic trigger (config = 30s)
  TestHarness->>MySQL: start/poll (every 30s)
  MySQL->>Purger: invoke purge cycle
  Purger->>Store: enumerate expired entries (sliding window)
  alt expired entries found
    Purger->>Store: delete expired entries
    Store-->>Purger: deletion results
  else none found
    Store-->>Purger: no-op
  end
  Purger-->>MySQL: report status
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • liunyl
  • MrGuin

Poem

I hopped through commits, nudged two submodule seeds,
Two purgers join the build to tend expired weeds.
Every thirty seconds the cloud garden clears,
I munch CI carrots and applaud tiny gears. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Standalone purger support" is concise and directly reflects the primary changes in the diff—adding purger-related source files, a purger periodicity configuration, and related submodule updates to enable a standalone purger. It clearly communicates the main intent without unnecessary detail or vague wording. Teammates scanning PR history should understand the primary purpose from this title.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5a6700 and 1863ea0.

📒 Files selected for processing (1)
  • storage/eloq/CMakeLists.txt (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • storage/eloq/CMakeLists.txt

Comment @coderabbitai help to get the list of available commands and usage tips.

@githubzilla githubzilla merged commit d2d97e6 into eloqdata:eloq-10.6.10 Sep 23, 2025
3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants