Skip to content

Fix slow open rocksdb cloud when db is large#120

Merged
githubzilla merged 3 commits intoeloqdata:eloq-10.6.10from
githubzilla:fix_slow_rocksdb_cloud_open
Sep 19, 2025
Merged

Fix slow open rocksdb cloud when db is large#120
githubzilla merged 3 commits intoeloqdata:eloq-10.6.10from
githubzilla:fix_slow_rocksdb_cloud_open

Conversation

@githubzilla
Copy link
Collaborator

@githubzilla githubzilla commented Sep 18, 2025

Summary by CodeRabbit

  • Chores
    • Internal submodule reference updated (metadata-only change).
    • No functional or public API changes introduced.
    • No user-facing impact; no action required.

@coderabbitai
Copy link

coderabbitai bot commented Sep 18, 2025

Walkthrough

Updated the storage/eloq/store_handler submodule pointer from commit ca901f647598f6d2ee19dd6f09dbfa16637deec1 to 7ca9d319d3d24a7185c3594b4af2c9ed74093774. Metadata-only; no code or API changes.

Changes

Cohort / File(s) Summary
Submodule pointer update
storage/eloq/store_handler
Submodule commit updated: ca901f647598f6d2ee19dd6f09dbfa16637deec17ca9d319d3d24a7185c3594b4af2c9ed74093774 (metadata-only).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • update subm #119 — Also updates the storage/eloq/store_handler submodule pointer to/from nearby commits; directly related pointer movement.
  • update subm #117 — Prior metadata-only pointer bump for the same submodule.

Poem

I hop a commit, tiny and spry,
From ca901f6 to 7ca9d3 I fly.
No code to nibble, no APIs fray,
Just a pointer hop to brighten the day. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title is specific and clearly states the intended bugfix (slow open of RocksDB cloud for large DBs), matching the branch name and PR objective; it is not vague or generic. The raw_summary shows the PR updates a submodule pointer (metadata-only in this repo), which likely brings the actual fix into tree, so the title is sufficiently related to the changeset's intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a44bc3f and 43f9f3c.

📒 Files selected for processing (1)
  • storage/eloq/store_handler (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • storage/eloq/store_handler

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
storage/eloq/store_handler (3)

1-1: Ensure CI fetches the updated submodule reliably.

Add/confirm these in CI before build:

  • git submodule sync --recursive
  • git submodule update --init --recursive --jobs 4
  • Avoid shallow submodule fetch if you rely on tags/desc.

1-1: Add a brief release note.

Note the store_handler bump and the performance win (“faster RocksDB Cloud open for large DBs”) for traceability.


1-1: Consider a lightweight regression check.

Add a smoke/benchmark (gated) that opens a large RocksDB Cloud DB and asserts open time stays under a threshold, to catch regressions in future submodule bumps.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f1d0dd and 21ca3a2.

📒 Files selected for processing (1)
  • storage/eloq/store_handler (1 hunks)
🔇 Additional comments (2)
storage/eloq/store_handler (2)

1-1: Submodule bump: bd836cda includes RocksDB Cloud open-time fix

bd836cda5a4f055ab480a481874c351ccfef5e4e (origin/fix_slow_rocksdb_cloud_open) is included in the bump; it changes only eloq_data_store_service/rocksdb_cloud_data_store.cpp and eloq_data_store_service/rocksdb_cloud_dump.cpp (61 insertions, 5 deletions) with commit message "open in one second" — the intended optimization is present and no other files were modified.


1-1: Guard against API/ABI drift: verify storage/eloq/store_handler public surfaces

Automated scan returned no output — verification inconclusive. Run the supplied diff script or manually diff public surfaces (include/, api/, public/, *.h, *.hpp, *.proto) between the previous and current submodule SHAs and confirm there are no breaking changes affecting callers.

@githubzilla githubzilla merged commit 09cf357 into eloqdata:eloq-10.6.10 Sep 19, 2025
2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants