Fix slow open rocksdb cloud when db is large#120
Fix slow open rocksdb cloud when db is large#120githubzilla merged 3 commits intoeloqdata:eloq-10.6.10from
Conversation
WalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
storage/eloq/store_handler (3)
1-1: Ensure CI fetches the updated submodule reliably.Add/confirm these in CI before build:
- git submodule sync --recursive
- git submodule update --init --recursive --jobs 4
- Avoid shallow submodule fetch if you rely on tags/desc.
1-1: Add a brief release note.Note the store_handler bump and the performance win (“faster RocksDB Cloud open for large DBs”) for traceability.
1-1: Consider a lightweight regression check.Add a smoke/benchmark (gated) that opens a large RocksDB Cloud DB and asserts open time stays under a threshold, to catch regressions in future submodule bumps.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
storage/eloq/store_handler(1 hunks)
🔇 Additional comments (2)
storage/eloq/store_handler (2)
1-1: Submodule bump: bd836cda includes RocksDB Cloud open-time fixbd836cda5a4f055ab480a481874c351ccfef5e4e (origin/fix_slow_rocksdb_cloud_open) is included in the bump; it changes only eloq_data_store_service/rocksdb_cloud_data_store.cpp and eloq_data_store_service/rocksdb_cloud_dump.cpp (61 insertions, 5 deletions) with commit message "open in one second" — the intended optimization is present and no other files were modified.
1-1: Guard against API/ABI drift: verify storage/eloq/store_handler public surfacesAutomated scan returned no output — verification inconclusive. Run the supplied diff script or manually diff public surfaces (include/, api/, public/, *.h, *.hpp, *.proto) between the previous and current submodule SHAs and confirm there are no breaking changes affecting callers.
Summary by CodeRabbit