chore: update concourse checkout scripts

[thweetkomputer]

Summary by CodeRabbit

• Chores

  • Updated build and release tooling to align with a reorganized module layout.
  • Adjusted ignore rules to match the reorganized structure.

• Bug Fixes

  • Improved error handling in release workflow to fail fast when expected release branches are missing.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Concourse CI scripts and .gitignore were updated to move several eloq module references into a new data_substrate subdirectory. Scripts now create symlinks, change directories, and reference release-branch targets under .../eloq/data_substrate/.... One script adds explicit error exits when expected release branches are missing.

Changes

Cohort / File(s)	Summary
Build & Tag script path updates concourse/scripts/build_tarball_open.bash, concourse/scripts/tag.sh	Updated symlink targets and working-directory pushd from src/mongo/db/modules/eloq/... to src/mongo/db/modules/eloq/data_substrate/.... Check symlink creation and relative link ordering.
Git checkout flow & error handling concourse/scripts/git-checkout.sh	Replaced module paths with data_substrate/* variants for eloq_log_service and raft_host_manager. In release-branch flow, added explicit error messages and exit 1 when expected release branches are absent. Review branch existence checks and exit behavior.
Git tagging release targets concourse/scripts/git-tag.sh	Adjusted three release-branch creation references to data_substrate-prefixed module paths: eloq_log_service, tx_service/raft_host_manager, and store_handler/.../eloqstore. Verify branch creation/push targets.
Repo ignore update .gitignore	Changed ignored path from src/mongo/db/modules/eloq/eloq_log_service to src/mongo/db/modules/eloq/data_substrate/eloq_log_service.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• update compile script for eloqstore #344: Updates Concourse build scripts to relocate eloq components into data_substrate and adjust linking/submodule steps.
• Update concourse config template #370: Modifies data_substrate submodule pointer and related configuration referenced by CI scripts.
• chore: update ci pipeline config of eloqstore #436: Changes Concourse CI handling of eloq data-store modules and their references under data_substrate.

Suggested reviewers

• yi-xmu
• githubzilla
• xiexiaoy

Poem

🐰 I hopped through paths and made a link,
Data substrate got a tiny wink,
Symlinks snug in tidy rows,
Branches checked where the release goes,
A little hop — CI happily blinks ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore: update concourse checkout scripts' accurately describes the main changes, which involve updating multiple concourse scripts (build_tarball_open.bash, git-checkout.sh, git-tag.sh, tag.sh) and .gitignore with new data_substrate paths.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@concourse/scripts/tag.sh`:
- Around line 9-12: Update the symlink created for eloq_log_service in the
tag.sh script: change the target path used in the ln -s invocation that
currently creates src/mongo/db/modules/eloq/eloq_log_service so it instead
creates src/mongo/db/modules/eloq/data_substrate/eloq_log_service, matching the
other build scripts (ensure the ln -s line referencing
$WORKSPACE/eloq_logservice_src is modified accordingly).

🧹 Nitpick comments (1)

concourse/scripts/git-checkout.sh (1)

35-46: Good addition of error handling; minor concern with checkout -b when branch already exists remotely.

The explicit error handling for missing release branches is a good improvement. However, git checkout -b "$REL_BRANCH" "origin/$REL_BRANCH" will fail if a local branch with the same name already exists (e.g., from a previous run). Consider using git checkout "$REL_BRANCH" or git switch -c "$REL_BRANCH" --track "origin/$REL_BRANCH" with appropriate error handling.

♻️ Suggested improvement for idempotent checkout

     if git ls-remote --heads origin "$REL_BRANCH" | grep -q "$REL_BRANCH"; then
-      git checkout -b "$REL_BRANCH" "origin/$REL_BRANCH"
+      git checkout "$REL_BRANCH" 2>/dev/null || git checkout -b "$REL_BRANCH" "origin/$REL_BRANCH"
     else