Update concourse config template

[liunyl]

Summary by CodeRabbit

• Chores
  • Updated threading and protocol configuration parameters for improved system initialization.
  • Streamlined cluster endpoint configuration naming conventions.
  • Removed unused cloud storage configuration settings.
  • Updated module dependencies to latest versions.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Ubuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Walkthrough

Configuration updates across ELOQ artifact directories: eloqdoc.conf modified with thread settings and ccProtocol addition while removing metrics/txService entries; rclone.ini's cloud storage section removed; data_substrate cluster configs renamed ip_port_list to tx_ip_port_list; data_substrate submodule pointer updated to new commit reference.

Changes

Cohort / File(s)	Summary
ELOQDSS_ELOQSTORE Configuration concourse/artifact/ELOQDSS_ELOQSTORE/eloqdoc.conf, concourse/artifact/ELOQDSS_ELOQSTORE/rclone.ini	eloqdoc.conf: Added net.adaptiveThreadNum and eloq.ccProtocol; removed adaptiveThreadNum, reservedThreadNum, txService, and metrics blocks. rclone.ini: Removed entire [eloqstore_cloud] GCS configuration section.
Data Substrate Cluster Configurations concourse/artifact/ELOQDSS_ROCKSDB/data_substrate.cnf, concourse/artifact/ELOQDSS_ROCKSDB_CLOUD_S3/data_substrate_cluster_[a-c].cnf	Renamed [cluster] configuration key ip_port_list to tx_ip_port_list across all cluster config files without altering endpoint values.
Submodule Reference src/mongo/db/modules/eloq/data_substrate	Updated gitlink commit reference from 0ee68ce2451e4a0f6a46b37f1d289038279ef4be to 0c6d86718056da1f764fe66e85e215cf6e4cd2fd.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Verify configuration key rename (ip_port_list → tx_ip_port_list) is consistent across all cluster environments and supported by dependent code
• Confirm implications of removing metrics/txService blocks from eloqdoc.conf and entire GCS cloud section from rclone.ini
• Validate submodule commit reference is correct and compatible with current codebase state

Possibly related PRs

• update submodule #341: Updates the same data_substrate submodule pointer to track latest changes
• Update kv metrics and refactor glog init #325: Modifies eloq storage metrics configuration with similar metrics block removals
• Update cluster config #290: Related to cluster configuration handling and uses of the ip_port_list/tx_ip_port_list cluster topology parameter

Suggested labels

trigger-ci

Suggested reviewers

• xiexiaoy
• lzxddz

Poem

🐰 Config keys dance and settings shift,
Metrics fade like morning mist,
Threads now two, submodule's swift,
Cloud goodbye, no need to lift,
All reborn, a faster gift! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Update concourse config template' is directly related to the main changes in the PR, which involve updates to multiple concourse configuration files across different artifact directories.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch update_config

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83690ed and bb02c37.

📒 Files selected for processing (7)

• concourse/artifact/ELOQDSS_ELOQSTORE/eloqdoc.conf (1 hunks)
• concourse/artifact/ELOQDSS_ELOQSTORE/rclone.ini (0 hunks)
• concourse/artifact/ELOQDSS_ROCKSDB/data_substrate.cnf (1 hunks)
• concourse/artifact/ELOQDSS_ROCKSDB_CLOUD_S3/data_substrate_cluster_a.cnf (1 hunks)
• concourse/artifact/ELOQDSS_ROCKSDB_CLOUD_S3/data_substrate_cluster_b.cnf (1 hunks)
• concourse/artifact/ELOQDSS_ROCKSDB_CLOUD_S3/data_substrate_cluster_c.cnf (1 hunks)
• src/mongo/db/modules/eloq/data_substrate (1 hunks)

💤 Files with no reviewable changes (1)

• concourse/artifact/ELOQDSS_ELOQSTORE/rclone.ini

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.

Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: concourse/scripts/main.ent.bash:38-39
Timestamp: 2025-11-28T10:52:25.527Z
Learning: In the eloqdoc enterprise build (main.ent.bash), eloq_log_service is fetched separately as the resource `eloq_logservice_src` in the pipeline (main.ent.yml) and then symlinked into the data_substrate directory structure at build time using `ln -s $WORKSPACE/eloq_logservice_src eloq_log_service`. This is the intended architecture for placing eloq_log_service within data_substrate in the enterprise configuration.

📚 Learning: 2025-11-28T10:55:21.020Z

Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.

Applied to files:

• concourse/artifact/ELOQDSS_ROCKSDB/data_substrate.cnf
• src/mongo/db/modules/eloq/data_substrate
• concourse/artifact/ELOQDSS_ELOQSTORE/eloqdoc.conf

🔇 Additional comments (7)

src/mongo/db/modules/eloq/data_substrate (1)

1-1: Verify the submodule commit contains matching code changes for configuration key names.

The PR updates some data_substrate configuration files from ip_port_list to tx_ip_port_list. Ensure the updated submodule commit handles both key names or has been updated to use the new naming consistently. Additionally, confirm the CMake build interface options (EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, STATISTICS) are still available and exposed correctly to dependent builds.

concourse/artifact/ELOQDSS_ROCKSDB_CLOUD_S3/data_substrate_cluster_a.cnf (1)

21-21: Configuration key rename is consistent.

The ip_port_list → tx_ip_port_list rename is consistent with the same change in other cluster configuration files. Verification requested in a previous file covers this change.

concourse/artifact/ELOQDSS_ROCKSDB/data_substrate.cnf (1)

18-18: Configuration key rename is consistent.

The ip_port_list → tx_ip_port_list rename matches the pattern across all data_substrate configurations. Verification in a previous file covers this change.

concourse/artifact/ELOQDSS_ROCKSDB_CLOUD_S3/data_substrate_cluster_b.cnf (1)

21-21: Configuration key rename is consistent across all files.

The ip_port_list → tx_ip_port_list rename is applied consistently across all data_substrate cluster configuration files in this PR. This completes the systematic update pattern.

concourse/artifact/ELOQDSS_ELOQSTORE/eloqdoc.conf (2)

19-19: No action needed — "OccRead" is a valid and recognized protocol value.

The ccProtocol value "OccRead" is one of three supported concurrency control protocols (OCC, OccRead, Locking) and is both documented and set as the default in the system. The configuration is correct and will not cause runtime errors or unexpected fallback behavior.

---

12-13: No issues found. The net.adaptiveThreadNum configuration key is valid and properly configured in eloqdoc.conf. The prerequisite setting serviceExecutor: "adaptive" is present on line 11, and the value of 2 meets the minimum requirement of 1.

concourse/artifact/ELOQDSS_ROCKSDB_CLOUD_S3/data_substrate_cluster_c.cnf (1)

21-21: The configuration key rename is consistent across all cluster configuration files.

All data_substrate cluster config files consistently use tx_ip_port_list in the [cluster] section (line 21 in cluster configs, line 18 in the single-node config). The old ip_port_list key has been completely removed from the codebase. However, since data_substrate is an external git submodule (https://github.com/eloqdata/tx_service.git), verification that the parser actually recognizes tx_ip_port_list requires access to that repository's source code and cannot be completed in this environment. Ensure the data_substrate submodule update in your PR dependencies includes support for this key.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[githubzilla]

+1