Skip to content

fix: put deleted keys with ttl when mvcc is enabled#426

Closed
thweetkomputer wants to merge 1 commit intoeloqdata:mainfrom
thweetkomputer:fix-range-putall-zc
Closed

fix: put deleted keys with ttl when mvcc is enabled#426
thweetkomputer wants to merge 1 commit intoeloqdata:mainfrom
thweetkomputer:fix-range-putall-zc

Conversation

@thweetkomputer
Copy link
Copy Markdown
Collaborator

@thweetkomputer thweetkomputer commented Jan 14, 2026

Summary by CodeRabbit

  • Chores
    • Updated internal dependency versions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 14, 2026

Walkthrough

This pull request updates the commit hash pointer for the src/mongo/db/modules/eloq/data_substrate submodule, advancing it from commit 25dd6a39cedb036e8ce849509245769fbcea48c7 to 3892ee23e527cab9fdd4824ddd78b2328605420c.

Changes

Cohort / File(s) Summary
Submodule Pointer Update
src/mongo/db/modules/eloq/data_substrate
Updated submodule commit reference to latest version

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • yi-xmu
  • liunyl
  • xiexiaoy

Poem

🐰 A submodule hops to a brand new hash,
Twenty-five to thirty-eight—what a dash!
Commits advance with a single-line leap,
The data substrate runs deep, deep, deep! 🌿

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is specific and directly related to the changeset, which updates a subproject commit hash for the eloq data substrate module.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7606226 and 697388d.

📒 Files selected for processing (1)
  • src/mongo/db/modules/eloq/data_substrate
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 211
File: src/mongo/db/modules/eloq/cmake/build_eloq_log_service.cmake:26-80
Timestamp: 2025-09-25T12:24:06.434Z
Learning: The user githubzilla implemented a fix in commit fe98aaf to address the MEMORY state incorrectly triggering RocksDB discovery in build_eloq_log_service.cmake. This was a control flow issue where MEMORY builds were falling into an else branch that still attempted RocksDB discovery.
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.
📚 Learning: 2025-11-28T10:55:21.020Z
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.

Applied to files:

  • src/mongo/db/modules/eloq/data_substrate
📚 Learning: 2025-09-25T12:24:06.434Z
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 211
File: src/mongo/db/modules/eloq/cmake/build_eloq_log_service.cmake:26-80
Timestamp: 2025-09-25T12:24:06.434Z
Learning: The user githubzilla implemented a fix in commit fe98aaf to address the MEMORY state incorrectly triggering RocksDB discovery in build_eloq_log_service.cmake. This was a control flow issue where MEMORY builds were falling into an else branch that still attempted RocksDB discovery.

Applied to files:

  • src/mongo/db/modules/eloq/data_substrate
🔇 Additional comments (1)
src/mongo/db/modules/eloq/data_substrate (1)

1-1: Verify that the submodule changes preserve the CMake option interface.

This PR updates the data_substrate submodule pointer. Since the parent CMakeLists.txt defines EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS options that are passed to this submodule, please verify:

  1. The new submodule commit (3892ee23e527cab9fdd4824ddd78b2328605420c) correctly uses these CMake options
  2. The fix for "put deleted keys with ttl when mvcc is enabled" does not change the expected behavior of these options
  3. No integration tests, configuration updates, or documentation changes are needed in the parent repository

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant