Update submodule for update datasyncscan execution#384
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughUpdate git submodule pointer for Changes
Sequence Diagram(s)Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/mongo/db/modules/eloq/data_substrate(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.
📚 Learning: 2025-11-28T10:55:21.020Z
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.
Applied to files:
src/mongo/db/modules/eloq/data_substrate
| @@ -1 +1 @@ | |||
| Subproject commit 01b396154133a25f7a49f6546d40bb7148cf2df6 | |||
| Subproject commit 617318868f5af9cf6db8a55646d05ff115f51698 | |||
There was a problem hiding this comment.
Provide details on the data_substrate submodule update and verify testing.
Submodule updates affecting core infrastructure require documentation of changes and verification of compatibility:
- Specify what changes are included in this submodule update, particularly improvements to "datasyncscan execution"
- Confirm testing was performed with the new submodule version
- Verify the new submodule maintains compatibility with the existing CMake build configuration, including the documented options (EXT_TX_PROC_ENABLED, STATISTICS, etc.)
- Note any new dependencies or API changes that could affect downstream consumers
7e102ac to
5bc361f
Compare
5bc361f to
be6f9c6
Compare
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.