Addressing SVG and YAML issues from #90#102
Conversation
…10277' into metadatacleaning
…into metadatacleaning
…nto metadatacleaning
…045' into metadatacleaning
Removed all empty keys and comments from the yaml file
…stfeld_2018_polycrystalline_17743_4b_1
|
@DunklesArchipel there is a merge conflict now. I had a quick look but I was not sure which of the two versions we want now. |
it's solved |
| source: | ||
| supplier: Merck, Suprapur, 99.99% | ||
| sum formula: LiF | ||
| supplier: Merck, Suprapur |
There was a problem hiding this comment.
Isn't the supplier just Merck? and Suprapur the brand name?
Anyway, I am also not sure what exactly is the meaning "supplied purity" and why this is not only called purity. And then why is the subkey "grade" needed at all. Couldn't it just be:
purity:
value: 99.99
unit: pct
But then it should probably not live under source.
But it also doesn't really matter. Just something I stumbled upon.
There was a problem hiding this comment.
I will address this aspect in #115.
@linuxrider and I had already a number of discussions about this aspect.
We did not yet consider the brand name
There was a problem hiding this comment.
Merck for example calls "Suprapur©" a grade.
Maybe our purity can hold a grade string.
|
@DunklesArchipel I looked randomly at some of the changes. But I didn't look at every single line. Maybe @linuxrider wants to have another quick look. |
linuxrider
left a comment
There was a problem hiding this comment.
Question about the format of the dates has to be addressed before merging.
It is a string in some cases and in other it seems to be of format date (yyyy-mm-dd).
The rest of the changes look good.
This PR addresses the most critical issues raised in #90.
The latest not yet merged literature up to #91 are included.
You can quickly browse through a few of the 250+ files. Replacements are always identical. If you think we need any other changes let me know.
Personally, I suggest keeping
https://doi.org/and also other instances with ahttppreamble, unless there is a good reason that we should not do that. With thehttppreamble these keys in the files become clickable in most editors, which I find very convenient.I would also change all filenames such that the figure identifier is always
*_f1a_*. Currently, in some cases, it is only1orFig1, etc..Note to reviewers:
pyandmdfiles.Dependencies:
cv.entryto match new metadata scheme (see #93) #105