Port System.Windows.Forms.Design components#632
Conversation
please remove Refers to: src/Common/src/CompModSwitches.cs:12 in 0acc17c. [](commit_id = 0acc17c839d686490efef0257478a271d6952e0d, deletion_comment = False) |
SetParent is already available here, you don;t have to add it in NativeMethods. Please review other methods that you added to NativeMethods class as well. Perhaps all you need to do is to change the call site to Refers to: src/Common/src/UnsafeNativeMethods.cs:1001 in 0acc17c. [](commit_id = 0acc17c839d686490efef0257478a271d6952e0d, deletion_comment = False) |
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/Adorner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/Adorner.cs
Outdated
Show resolved
Hide resolved
...m.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/ContainerSelectorBehavior.cs
Outdated
Show resolved
Hide resolved
0acc17c to
1969dc2
Compare
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
===================================================
- Coverage 27.34119% 25.88078% -1.46041%
===================================================
Files 948 975 +27
Lines 254700 268427 +13727
Branches 33853 35934 +2081
===================================================
- Hits 69638 69471 -167
- Misses 181175 195083 +13908
+ Partials 3887 3873 -14
|
|
Thanks for the comments, all addressed/fixed |
|
LGTM @JuditRose |
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.cs
Show resolved
Hide resolved
| // I don't think so, because the malicious control would still be on the frame. | ||
| new NamedPermissionSet("FullTrust").Assert(); | ||
|
|
||
| foreach (AdornerWindow adornerWindow in AdornerWindow.s_adornerWindowList) |
There was a problem hiding this comment.
this is related to CAS, can go away
There was a problem hiding this comment.
Which part can go away?
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/BehaviorService.cs
Outdated
Show resolved
Hide resolved
...dows.Forms.Design/src/System/Windows/Forms/Design/Behavior/DesignerActionKeyboardBehavior.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/DragAssistanceManager.cs
Show resolved
Hide resolved
...ystem.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/DragAssistanceManager.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/DropSourceBehavior.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/DropSourceBehavior.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/SelectionManager.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, thanks!
Fixes #585
Components copied from framework.