Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
===================================================
- Coverage 27.54871% 26.97608% -0.57263%
===================================================
Files 926 944 +18
Lines 247910 254114 +6204
Branches 32774 33849 +1075
===================================================
+ Hits 68296 68550 +254
- Misses 175785 181717 +5932
- Partials 3829 3847 +18
|
...esign/src/System/ComponentModel/Design/Serialization/CodeDomComponentSerializationService.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
suggested changes
Mar 21, 2019
Contributor
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, I have only "clean up" level change requests. Mainly - please add nameof to throw statements as needed. I did not mark all occurrences in the code. Then please review your changes if string.Format is used appropriately with resources that actually are format strings and as such require arguments. I did not see any problems in this area, but it is hard to review in a browser.
...esign/src/System/ComponentModel/Design/Serialization/CodeDomComponentSerializationService.cs
Outdated
Show resolved
Hide resolved
...esign/src/System/ComponentModel/Design/Serialization/CodeDomComponentSerializationService.cs
Show resolved
Hide resolved
...tem.Windows.Forms.Design/src/System/ComponentModel/Design/Serialization/CodeDomSerializer.cs
Outdated
Show resolved
Hide resolved
...Windows.Forms.Design/src/System/ComponentModel/Design/Serialization/CodeDomSerializerBase.cs
Outdated
Show resolved
Hide resolved
...Windows.Forms.Design/src/System/ComponentModel/Design/Serialization/CodeDomSerializerBase.cs
Outdated
Show resolved
Hide resolved
...Windows.Forms.Design/src/System/ComponentModel/Design/Serialization/CodeDomSerializerBase.cs
Outdated
Show resolved
Hide resolved
...s.Forms.Design/src/System/ComponentModel/Design/Serialization/CollectionCodeDomSerializer.cs
Outdated
Show resolved
Hide resolved
...tem.Windows.Forms.Design/src/System/ComponentModel/Design/Serialization/ExpressionContext.cs
Show resolved
Hide resolved
Contributor
Author
|
All comments fixed, thanks for the review |
zsd4yr
approved these changes
Mar 25, 2019
Contributor
zsd4yr
left a comment
There was a problem hiding this comment.
One nit change; please address and then otherwise LGTM
...System.Windows.Forms.Design/tests/UnitTests/Serialization/CodeDomSerializerExceptionTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #608
Contributes to #221
Components are ported from framework.