Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

Add string overloads to DbDataReader.Get*()#1290

Merged
wtgodbe merged 2 commits into
dotnet:masterfrom
roji:DbDataReaderStringOverloads
Jul 2, 2019
Merged

Add string overloads to DbDataReader.Get*()#1290
wtgodbe merged 2 commits into
dotnet:masterfrom
roji:DbDataReaderStringOverloads

Conversation

@roji

@roji roji commented Jun 28, 2019

Copy link
Copy Markdown
Member

See https://github.com/dotnet/corefx/issues/31595

This is the 3rd and last in this batch of System.Data changes.

Note that for the naming and namespace for the new DataReaderExtensions class, see dotnet/corefx#36123 (comment) and dotnet/corefx#36123 (comment).

@roji roji requested review from a team as code owners June 28, 2019 12:11
@roji

roji commented Jun 28, 2019

Copy link
Copy Markdown
Member Author

/cc @divega @terrajobst

Comment thread src/netstandard/ref/System.Data.cs
@terrajobst

Copy link
Copy Markdown

Tagging @agocke

@terrajobst terrajobst added the netstandard-api This tracks requests for standardizing APIs. label Jul 2, 2019
@terrajobst terrajobst added this to the .NET Standard 2.1 milestone Jul 2, 2019
@terrajobst

Copy link
Copy Markdown

@roji

Please resolve the merge conflicts by doing this:

git checkout master
git pull
git checkout DbDataReaderStringOverloads
git rebase master
git reset src/netstandard/src/ApiCompatBaseline.*
git checkout src/netstandard/src/ApiCompatBaseline.*
.\build.cmd
git add .
git rebase --continue
git push origin DbDataReaderStringOverloads -f

@wtgodbe

wtgodbe commented Jul 2, 2019

Copy link
Copy Markdown
Member

Approved for preview7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

netstandard-api This tracks requests for standardizing APIs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants