Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[master] Update dependencies from dotnet/standard#39283

Merged
stephentoub merged 3 commits into
masterfrom
darc-master-5eec0294-078d-44c2-9f75-dd07240c466c
Jul 9, 2019
Merged

[master] Update dependencies from dotnet/standard#39283
stephentoub merged 3 commits into
masterfrom
darc-master-5eec0294-078d-44c2-9f75-dd07240c466c

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jul 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/standard

  • Build: 20190708.2
  • Date Produced: 7/8/2019 1:22 PM
  • Commit: 46d64281c0848ee208045ba2d59d7059ce680266
  • Branch: refs/heads/master
  • Updates:
    • NETStandard.Library -> 2.1.0-prerelease.19358.2

Update dependencies from https://github.com/dotnet/standard build 201…
686169d 
…90708.1

- NETStandard.Library - 2.1.0-prerelease.19358.1
@dotnet-maestro

dotnet-maestro Bot commented Jul 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Windows UWP_CoreCLR_x64_Debug), corefx-ci (Windows x86_Release), corefx-ci (Windows x64_Debug), corefx-ci (MacOS x64_Debug), corefx-ci (Linux musl_x64_Debug), corefx-ci (Linux x64_Debug), corefx-ci (Linux arm64_Debug), corefx-ci (Linux RedHat6_x64_Release), corefx-ci (Linux musl_arm64_Debug), corefx-ci (Linux arm_Debug), corefx-ci (Packaging All Configurations x64_Debug)

@stephentoub

stephentoub commented Jul 8, 2019

Copy link
Copy Markdown
Member 
D:\a\1\s\src\shims\ApiCompat.proj(82,5): error : CannotRemoveBaseTypeOrInterface : Type 'System.Data.DataTableReader' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
##[error]src\shims\ApiCompat.proj(82,5): error : CannotRemoveBaseTypeOrInterface : Type 'System.Data.DataTableReader' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
D:\a\1\s\src\shims\ApiCompat.proj(82,5): error : CannotRemoveBaseTypeOrInterface : Type 'System.Data.Common.DbCommand' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
##[error]src\shims\ApiCompat.proj(82,5): error : CannotRemoveBaseTypeOrInterface : Type 'System.Data.Common.DbCommand' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
D:\a\1\s\src\shims\ApiCompat.proj(82,5): error : CannotRemoveBaseTypeOrInterface : Type 'System.Data.Common.DbConnection' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
##[error]src\shims\ApiCompat.proj(82,5): error : CannotRemoveBaseTypeOrInterface : Type 'System.Data.Common.DbConnection' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
D:\a\1\s\src\shims\ApiCompat.proj(82,5): error : CannotRemoveBaseTypeOrInterface : Type 'System.Data.Common.DbDataReader' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
##[error]src\shims\ApiCompat.proj(82,5): error : CannotRemoveBaseTypeOrInterface : Type 'System.Data.Common.DbDataReader' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
D:\a\1\s\src\shims\ApiCompat.proj(82,5): error : CannotRemoveBaseTypeOrInterface : Type 'System.Data.Common.DbTransaction' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
##[error]src\shims\ApiCompat.proj(82,5): error : CannotRemoveBaseTypeOrInterface : Type 'System.Data.Common.DbTransaction' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
D:\a\1\s\src\shims\ApiCompat.proj(90,5): error : ApiCompat failed comparing netstandard.dll to netcoreapp
##[error]src\shims\ApiCompat.proj(90,5): error : ApiCompat failed comparing netstandard.dll to netcoreapp

@dotnet-maestro

dotnet-maestro Bot commented Jul 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux musl_x64_Debug), corefx-ci (Linux x64_Debug), corefx-ci (MacOS x64_Debug), corefx-ci (Linux RedHat6_x64_Release), corefx-ci (Linux arm64_Debug), corefx-ci (Linux musl_arm64_Debug), corefx-ci (Windows UWP_CoreCLR_x64_Debug), corefx-ci (Linux arm_Debug), corefx-ci (Windows x86_Release), corefx-ci (Windows x64_Debug), corefx-ci (Packaging All Configurations x64_Debug)

Update dependencies from https://github.com/dotnet/standard build 201…
7e9620b 
…90708.2

- NETStandard.Library - 2.1.0-prerelease.19358.2
@safern

safern commented Jul 8, 2019

Copy link
Copy Markdown
Member

cc: @wtgodbe

@wtgodbe

wtgodbe commented Jul 8, 2019

Copy link
Copy Markdown
Member

Looking

@safern safern mentioned this pull request Jul 8, 2019
Closed
@wtgodbe

wtgodbe commented Jul 8, 2019

Copy link
Copy Markdown
Member

dotnet/standard#1290, dotnet/standard#1304

@wtgodbe wtgodbe closed this Jul 8, 2019
@wtgodbe wtgodbe reopened this Jul 8, 2019
@stephentoub stephentoub merged commit 50de559 into master Jul 9, 2019
@stephentoub stephentoub deleted the darc-master-5eec0294-078d-44c2-9f75-dd07240c466c branch July 9, 2019 03:07
@karelz karelz added this to the 3.0 milestone Jul 16, 2019
@terrajobst

terrajobst commented Sep 6, 2019

Copy link
Copy Markdown

@wtgodbe @stephentoub

Next time we should file tracking bugs when adding stuff to the baseline file. In this case, this is a real bug that we didn't catch :-(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@stephentoub @safern @wtgodbe @terrajobst @karelz