Conversation
The enables the automation of running the emit unit tests for Linux/Mac
|
Also, @TIHan @amanasifkhalid as this might be useful for testing your encoding patches. |
| @@ -0,0 +1,115 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Thanks for doing this @a74nh . Perhaps, we should have a python script instead, so it can be used on all platforms.
There was a problem hiding this comment.
That should be possible to just convert across. this might be a good time to try the Arm64 Windows box we've got.
There was a problem hiding this comment.
yes, but IMO having 2 copies for different platform, makes us remember to make changes on both the scripts and soon one might get outdated with respect to other.
this might be a good time to try the Arm64 Windows box we've got
with python, you might not even have to do it ;)
Change-Id: I14896011fbe7aa5be25c425a9a38fa9ec5c56ebd
BruceForstall
left a comment
There was a problem hiding this comment.
I think this is fine as-is for its purpose for doing this development. Arguably, it should live in jitutils instead (opinions?).
Having a follow-up so it works on Windows might be useful, but maybe unnecessary depending on the users. And not worth gating this on the conversion. Seems like support for altjit might be useful (e.g., doing development on win-x64 using altjit).
As for putting it in CI, I'm not sure how valuable that would be. It would be problematic to depend on cloning/building a "private" repo (capstone).
+1 |
If the others doing the SVE codegen (@TIHan, @amanasifkhalid) would use this on Windows then I'm happy to port. Otherwise, lets keep it as bash then.
My concern was making sure it can easily be re-run, and the code not rot. Doesn't have to go in the CI. |
I develop primarily on Windows, but having a Windows port of this is not a huge priority for me. |
BruceForstall
left a comment
There was a problem hiding this comment.
Let's go ahead and add merge this as-is.
The enables the automation of running the emit unit tests for Linux/Mac. Including testing against capstone.
This builds on top of #96005
The intention is for this script to be used during development and eventually added to the CI. I'm not sure what CI conventions I'm missing and I'm not sure if this would require a Windows version.