Gate emit unit tests on JitDumpEmitUnitTests instead of define#96005
Gate emit unit tests on JitDumpEmitUnitTests instead of define#96005kunalspathak merged 3 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Detailsnull
|
aae7f4d to
cff8d87
Compare
|
@kunalspathak @BruceForstall - as suggested on #95918 |
4c1c3da to
2764b13
Compare
2764b13 to
8532427
Compare
BruceForstall
left a comment
There was a problem hiding this comment.
This looks great, except it looks like some "garbage" code to be removed.
As a follow-up, I think we should move all the arm64 unit tests to a separate file (named codegenarm64test.cpp?) since they're now over 5000 lines in this 11000 line file.
Done. |
|
seems like we don't need the runtime/src/coreclr/jit/codegenxarch.cpp Lines 9048 to 9052 in 6d0a902 |
kunalspathak
left a comment
There was a problem hiding this comment.
LGTM. Thanks for doing it.
| // given set of stress mode names, e.g. STRESS_REGS, | ||
| // STRESS_TAILCALL | ||
| CONFIG_STRING(JitStressRange, W("JitStressRange")) // Internal Jit stress mode | ||
| CONFIG_STRING(JitDumpEmitUnitTests, W("JitDumpEmitUnitTests")) // Dump unit tests from Emit |
There was a problem hiding this comment.
nit: will be good to mention example usage like should they be comma-separated, etc. May be in a follow-up PR.
I originally had this check in the new common function. But then Arm64 testing would always exit without doing the tests. So, I removed it for all targets because it's gated by the config option anyway. |
genEmitterUnitTests()JitDumpEmitUnitTestsinstead of using#defines.