Skip to content

Remove DotNetHost, DotNetHostPolicy, and DotNetHostResolver packages#91655

Merged
elinor-fung merged 2 commits intodotnet:mainfrom
elinor-fung:deleteHostPkgs
Sep 6, 2023
Merged

Remove DotNetHost, DotNetHostPolicy, and DotNetHostResolver packages#91655
elinor-fung merged 2 commits intodotnet:mainfrom
elinor-fung:deleteHostPkgs

Conversation

@elinor-fung
Copy link
Member

These are old packages (just contain dotnet, hostpolicy, hostfxr) that we no longer need. We had been relying on them for publishing symbols, but with #91031, symbols should be in other packages now (checked the publishing assets/symbols build log), so we can remove these packages and associated infrastructure only used by them.

Fixes #35244

cc @ViktorHofer

@ghost
Copy link

ghost commented Sep 6, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

These are old packages (just contain dotnet, hostpolicy, hostfxr) that we no longer need. We had been relying on them for publishing symbols, but with #91031, symbols should be in other packages now (checked the publishing assets/symbols build log), so we can remove these packages and associated infrastructure only used by them.

Fixes #35244

cc @ViktorHofer

Author: elinor-fung
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@@ -1,9 +1,6 @@
<Project Sdk="Microsoft.Build.Traversal" DefaultTargets="Pack">
<ItemGroup>
<ProjectReference Include="Microsoft.NETCore.DotNetAppHost\Microsoft.NETCore.DotNetAppHost.pkgproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That package is still needed, right? It would be amazing if we would convert it from a pkgproj to a normal .proj and use NuGet's Pack task, so that we can remove all the pkgproj infrastructure from src/installer/*. As part of that, we should probably also move the package wrapper project to the host directory.

pkgprojs are deprecated and we want to eventually remove all of them from dotnet/runtime.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this one has binaries folks would use for custom hosting scenarios. I imagine we could/should convert it - that said, I'm not familiar with the differences between pkgproj / regular NuGet Pack.

I think the pkgproj infrastructure in src/installer is also used by Microsoft.DotNet.ILCompiler though: https://github.com/dotnet/runtime/blob/76d17b25252ce14b7e36c2e6854fe416db60f5cf/src/installer/pkg/projects/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.pkgproj

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sweet!

@agocke
Copy link
Member

agocke commented Sep 6, 2023

image

@elinor-fung elinor-fung merged commit f76045c into dotnet:main Sep 6, 2023
@elinor-fung elinor-fung deleted the deleteHostPkgs branch September 6, 2023 22:24
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Microsoft.NETCore.DotNetHost NuGet packages

4 participants