Skip to content

Include dotnet/hostfxr/hostpolicy symbols in Microsoft.NETCore.App.Host/Runtime packages#91031

Merged
elinor-fung merged 1 commit intodotnet:mainfrom
elinor-fung:hostSymbolsPkg
Sep 5, 2023
Merged

Include dotnet/hostfxr/hostpolicy symbols in Microsoft.NETCore.App.Host/Runtime packages#91031
elinor-fung merged 1 commit intodotnet:mainfrom
elinor-fung:hostSymbolsPkg

Conversation

@elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Aug 23, 2023

We're currently relying on some old host packages to get symbols published. This adds those symbols to existing shipping packages.

  • Add symbols for hostfxr and hostpolicy to the Microsoft.NETCore.App.Runtime package
  • Add symbols for dotnet to the Microsoft.NETCore.App.Host package
  • Fix non-Windows symbols not being included in Microsoft.NETCore.App.Host package

This should allow us to remove the old packages: #35244

@elinor-fung elinor-fung requested a review from agocke August 23, 2023 22:13
@ghost ghost added the area-Setup label Aug 23, 2023
@ghost ghost assigned elinor-fung Aug 23, 2023
@ghost
Copy link

ghost commented Aug 23, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

We're currently relying on some old host packages to get symbols published. This adds those symbols to existing shipping packages.

  • Add symbols for hostfxr and hostpolicy to the Microsoft.NETCore.App.Runtime package
  • Add symbols for dotnet to the Microsoft.NETCore.App.Host package
  • Fix non-Windows symbols not being included in Microsoft.NETCore.App.Host package

This should allow us to do remove the old packages: #35244

Author: elinor-fung
Assignees: elinor-fung
Labels:

area-Host

Milestone: -

@elinor-fung
Copy link
Member Author

@agocke @jkoritzinsky could one of you take a look here? This is just adding the host symbols to existing packages. I plan to do a follow-up to remove the old packages after this.

@elinor-fung elinor-fung merged commit cf65ea2 into dotnet:main Sep 5, 2023
@elinor-fung elinor-fung deleted the hostSymbolsPkg branch September 5, 2023 18:44
@ghost ghost locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants