Skip to content

Add test global install path is used when DOTNET_ROOT does not exist #54883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateoatr merged 6 commits into from
Jul 6, 2021
Merged

Add test global install path is used when DOTNET_ROOT does not exist #54883

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d45566c
Add test
Jun 28, 2021
0e69767
PR feedback
Jun 29, 2021
bd8bdfc
Update tests
Jul 1, 2021
6d654a1
Use product behavior for test where DOTNET_ROOT exists but has no host
Jul 1, 2021
d9bb5ad
Fix test
Jul 1, 2021
62dc62f
Get platform specific extension for hostfxr
Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions src/installer/tests/HostActivation.Tests/MultiArchInstallLocation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,56 @@ public void EnvironmentVariable_ArchSpecificDotnetRootIsUsedOverDotnetRoot()
.And.NotHaveStdErrContaining("Using environment variable DOTNET_ROOT=");
}

[Fact]
public void EnvironmentVariable_DotnetRootPathDoesNotExist()
{
var fixture = sharedTestState.PortableAppFixture
.Copy();

var appExe = fixture.TestProject.AppExe;
using (TestOnlyProductBehavior.Enable(appExe))
{
Command.Create(appExe)
.EnableTracingAndCaptureOutputs()
.DotNetRoot("non_existent_path")
.MultilevelLookup(false)
.EnvironmentVariable(
Constants.TestOnlyEnvironmentVariables.GloballyRegisteredPath,
sharedTestState.InstallLocation)
.Execute()
.Should().Pass()
.And.HaveStdErrContaining("Did not find [DOTNET_ROOT] directory [non_existent_path]")
// If DOTNET_ROOT points to a folder that does not exist, we fall back to the global install path.
.And.HaveUsedGlobalInstallLocation(sharedTestState.InstallLocation)
.And.HaveStdOutContaining("Hello World");
}
}

[Fact]
public void EnvironmentVariable_DotnetRootPathExistsButHasNoHost()
{
var fixture = sharedTestState.PortableAppFixture
.Copy();

var appExe = fixture.TestProject.AppExe;
var projDir = fixture.TestProject.ProjectDirectory;
using (TestOnlyProductBehavior.Enable(appExe))
{
Command.Create(appExe)
.EnableTracingAndCaptureOutputs()
.DotNetRoot(projDir)
.MultilevelLookup(false)
.EnvironmentVariable(
Constants.TestOnlyEnvironmentVariables.GloballyRegisteredPath,
sharedTestState.InstallLocation)
.Execute()
.Should().Fail()
.And.HaveUsedDotNetRootInstallLocation(projDir, fixture.CurrentRid)
// If DOTNET_ROOT points to a folder that exists we assume that there's a dotnet installation in it
.And.HaveStdErrContaining($"A fatal error occurred. The required library {RuntimeInformationExtensions.GetSharedLibraryFileNameForCurrentPlatform ("hostfxr")} could not be found.");
}
}

[Fact]
[SkipOnPlatform(TestPlatforms.Windows, "This test targets the install_location config file which is only used on Linux and macOS.")]
public void InstallLocationFile_ArchSpecificLocationIsPickedFirst()
Expand Down Expand Up @@ -173,6 +223,7 @@ public SharedTestState()

PortableAppFixture = fixture;
BaseDirectory = Path.GetDirectoryName(PortableAppFixture.SdkDotnet.GreatestVersionHostFxrFilePath);
InstallLocation = fixture.BuiltDotnet.BinPath;
}

public void Dispose()
Expand Down