Add test global install path is used when DOTNET_ROOT does not exist#54883
Merged
mateoatr merged 6 commits intodotnet:mainfrom Jul 6, 2021
Merged
Add test global install path is used when DOTNET_ROOT does not exist#54883mateoatr merged 6 commits intodotnet:mainfrom
mateoatr merged 6 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsThe global installation path should be used when
|
elinor-fung
reviewed
Jun 29, 2021
src/installer/tests/HostActivation.Tests/MultiArchInstallLocation.cs
Outdated
Show resolved
Hide resolved
Add test covering case where DOTNET_ROOT exists but does not have a dotnet installation on it
elinor-fung
reviewed
Jun 30, 2021
src/installer/tests/HostActivation.Tests/MultiArchInstallLocation.cs
Outdated
Show resolved
Hide resolved
src/installer/tests/HostActivation.Tests/MultiArchInstallLocation.cs
Outdated
Show resolved
Hide resolved
src/installer/tests/HostActivation.Tests/MultiArchInstallLocation.cs
Outdated
Show resolved
Hide resolved
src/installer/tests/HostActivation.Tests/MultiArchInstallLocation.cs
Outdated
Show resolved
Hide resolved
src/installer/tests/HostActivation.Tests/MultiArchInstallLocation.cs
Outdated
Show resolved
Hide resolved
elinor-fung
reviewed
Jul 2, 2021
src/installer/tests/HostActivation.Tests/MultiArchInstallLocation.cs
Outdated
Show resolved
Hide resolved
Use HaveUsedNetRootInstallLocation
elinor-fung
approved these changes
Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global installation path should be used when
DOTNET_ROOTis specified but the path it points to does not exist.