Support Write-Thru of EH variables in LSRA by CarolEidt · Pull Request #543 · dotnet/runtime

CarolEidt · 2019-12-05T02:02:40Z

Mark EH variables (those that are live in or out of exception regions) only as lvLiveInOutOfHndlr, not necessarily lvDoNotEnregister.
During register allocation, mark these as write-thru, and mark all defs as write-thru, ensuring that the stack value is always valid.
Mark those defs with GTF_SPILLED (this the "reload" flag and is not currently used for pure defs) to indicate that it should be kept in the register.
Mark blocks that enter EH regions as having no predecessor, and set the location of all live-in vars to be on the stack.
Change genFnPrologCalleeRegArgs to store EH vars also to the stack if they have a register assignment.

CarolEidt · 2019-12-05T19:40:42Z

@dotnet/jit-contrib PTAL

sandreenko

I expect that change has an impact on throughput and memory consumption, how big is it?

The implementation looks good, but I am scared to have so many places where we check writeThru, that means it will be very easy to forget some of them.

sandreenko · 2019-12-13T23:16:36Z

src/coreclr/src/jit/lsra.h

should not it be declared as a bitfield?

I moved this field from the base type (Referenceable) to Interval, and changing it to a bitfield seemed to have a minor negative impact.

sandreenko · 2019-12-13T23:21:50Z

src/coreclr/src/jit/compiler.h

the same question why it is not a bitfield.

We don't currently have any bitfields on Compiler, and given that there is only one instance per compilation, it seems that the efficiency of querying a byte overrides the storage impact.

sandreenko · 2019-12-13T23:30:49Z

src/coreclr/src/jit/instr.cpp

typo: memroy

sandreenko · 2019-12-13T23:37:04Z

src/coreclr/src/jit/instr.cpp

what do we actually need to know here:

is the value valid in memory?

is the value valid in a register?

looks like the second, so maybe rename isSpilledValue to validInReg?

Makes sense. With the removal of legacy jit, I'm pretty sure this code is only used for lclVar spilling, so I think I'll try to simplify it.

sandreenko · 2019-12-13T23:44:05Z

src/coreclr/src/jit/lclvars.cpp

What will happen if lsra::enregisterLocalVars and compiler::lvaEnregEHVars have different values, for example enregisterLocalVars==false and lvaEnregEHVars==true, will we try allocate registers for such variables or not?
If now why do we need a separate flag?

Although I hadn't added it yet, I anticipated having a COMPlus variable to separately control this (which I'm hopefully about to push as an update to this PR). However, LSRA uses the condition above to set enregisterLocalVars so it wouldn't be possible to have lvaEnregEHVars be true and enregisterLocalVars be false.

sandreenko · 2019-12-14T00:11:13Z

src/coreclr/src/jit/codegencommon.cpp

maybe // if only register homed go to the next one?

How about // If this arg is never on the stack, go to the next one.?

sandreenko · 2019-12-14T00:18:56Z

src/coreclr/src/jit/codegenlinear.cpp

Could you please update that comment so it includes normal spills, not only lvLiveInOutOfHndlr, because, at least for me, that was not obvious after the first read.

Agree, this comment is a bit confusing...

This still seems confusing, the comment is talking about GTF_SPILL but the code you changed here does not look at this flag.

I've pushed another change to this comment, hopefully making it clear.

I think that's better, yes. @sandreenko do you agree?

sandreenko · 2019-12-14T00:39:55Z

src/coreclr/src/jit/lsra.cpp

That change confuses me, but since hasEHBoundaryIn was not used before that PR there could not be any regressions from that.

What this does is change the block to have no predecessor, so that it doesn't have to deal with mismatched locations of EH vars across the boundary. However, this change actually causes some small diffs when the EH write-thru is disabled, because it creates mismatches on the non-EH edges. I'm looking into how complex it would be to eliminate this change, but it may be excessively complex. The crossgen diffs over all jits & altjits for frameworks & tests shows only 4 bytes of diff each over two large methods for arm32, and 40 bytes of diff for one 4020 byte method for x64/ux altjit.

sandreenko · 2019-12-14T01:02:19Z

src/coreclr/src/jit/lsra.cpp

I think that was part was already merged in #679, why does github show that as a diff?

I believe it's because this is actually showing the original change that I extracted for that PR. I haven't yet pushed a rebased version of this PR.

sandreenko · 2019-12-14T01:12:21Z

src/coreclr/src/jit/lsrabuild.cpp

Could you please explain how this PR relates to the deletion of block != compiler->fgFirstBB condition here?

With this PR, we have blocks with an incoming EH boundary that may have live-in candidate vars. Previously those vars would have no live-in candidate vars, by construction, so we didn't need to worry about whether they needed dummy defs. Now that we have live-in EH vars, we don't want dummy defs for those (they should always be on stack on entry), so they are treated as having no pred block (like fgFirstBB), and that becomes the right condition for determining when we don't want dummy defs.

CarolEidt · 2019-12-17T00:08:42Z

I expect that change has an impact on throughput and memory consumption, how big is it?

The Throughput tuning commit brings this from roughly a .05% throughput loss on x64 (in the noise on x86) to a .05% improvement on x64 and a .007% improvement (barely above the noise) on x86 for crossgen of SPC.dll

The implementation looks good, but I am scared to have so many places where we check writeThru, that means it will be very easy to forget some of them.

I'm not sure I fully understand. This is pretty fundamental, as these variables need to be handled differently.

AndyAyersMS

Some initial comments. Still need to look through lsra.cpp ...

AndyAyersMS · 2019-12-17T18:52:20Z

src/coreclr/src/jit/compiler.h

Can you update the text for this when we dump the local var table? In existing code this is debug only and only gets dumped if the local is DNER. Would be nice to have it show up more prominently.

I've added an " EH" annotation unconditionally, and left the 'H' character in the DNER dump.

AndyAyersMS · 2019-12-17T18:55:08Z

src/coreclr/src/jit/codegenlinear.cpp

Agree, this comment is a bit confusing...

AndyAyersMS · 2019-12-17T18:56:44Z

src/coreclr/src/jit/codegencommon.cpp

Should we consider any of these lvLiveInOutofHndlr asserts as candidates for noway_assert?

I've pretty much left the assert\noway_assert distinction as-is - these are generally just either expanding or contracting the condition for an assert.

AndyAyersMS · 2019-12-17T19:07:45Z

src/coreclr/src/jit/lclvars.cpp

Is there some other way to accomplish this? I never like to see us bias this sort of accounting if we can avoid it.

Say down the road we want to use weighted ref counts for other optimizations -- for instance trying to allocate the most frequently accessed locals at small FP or SP offsets -- we'd want these weighted ref counts to reflect our best model of reality.

This is tricky because of the way we overload the ref counts for use by optimization and register allocation - the register allocator uses the weight to determine the value of allocating a register.
Note that this is only the IsLir() path.

AndyAyersMS · 2019-12-17T19:10:33Z

...braries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncMethodBuilderCore.cs

Would be good to post diffs for these (maybe in a gist). Also when these "manual write-thru" changes were added there was some kind of perf testing -- have you looked at trying to revisit those tests?

Ditto for the other Fx edits below...

I am unaware of perf testing that was done when those mitigations were added - @stephentoub do you know how those might have been tested?

There are some perf tests in dotnet/coreclr#15629.

AndyAyersMS · 2019-12-19T19:14:32Z

Possible follow-up: seems like this change might allow us to get rid of the lvVolatileHint computations we do in lvaMarkLclRefs and the code to copy volatile hinted locals in optAddCopies.

Also if you're interested in stress-testing, you might try the mutate-test tool from jitutils, it can introduce EH into all methods in a test case.

CarolEidt · 2019-12-19T19:18:31Z

@AndyAyersMS - thanks. Right now I'm working on getting this checked in disabled. Turns out there are some minor regressions due to the way block boundaries are handled. I'm trying to get those eliminated. At that point it would be interesting to work on the stress testing; I think the other is best to leave for later.

AndyAyersMS · 2019-12-19T19:23:37Z

src/coreclr/src/jit/lsrabuild.cpp

Can you (perhaps in a comment) explain this part of the change?

AndyAyersMS · 2019-12-19T19:27:35Z

src/coreclr/src/jit/lsrabuild.cpp

I take it this is the matching bit of logic for line 1185?

Yes, I'll add a pointer

AndyAyersMS · 2019-12-19T19:35:23Z

Have now looked over everything but lsra.cpp; not sure how much help I can be with the changes there.

CarolEidt · 2020-02-01T00:24:21Z

@dotnet/jit-contrib - This is ready for review. It is disabled by default and there are zero diffs.

CarolEidt · 2020-02-01T00:25:27Z

I plan to rebase and run jitstress jitstressregs once my two stress fixes are merged.

CarolEidt · 2020-02-12T16:20:08Z

/azp run runtime-coreclr jitstress2-jitstressregs

azure-pipelines · 2020-02-12T16:20:14Z

No pipelines are associated with this pull request.

echesakov · 2020-02-12T18:32:13Z

/azp list

azure-pipelines · 2020-02-12T18:32:18Z

CI/CD Pipelines for this repository: coreclr-gc-longrunning coreclr-gc-simulator runtime-coreclr outerloop runtime-coreclr crossgen2 runtime-libraries outerloop runtime-libraries outerloop-windows runtime-libraries outerloop-linux runtime-libraries outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-live-build runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly sync-runtime-to-mono

lpereira · 2020-02-12T23:47:05Z

src/coreclr/src/jit/treelifeupdater.cpp

Would these changes from else to if (isInMemory) be better as else if (isInMemory) with another else with a noway_assert()?

No; the whole point of this change is that a variable can now be valid both in register and in memory, because when we "write-thru" a definition of an EH exposed variable it can remain live in the register as well.

CarolEidt · 2020-02-18T18:36:34Z

@dotnet/jit-contrib ping

AndyAyersMS

Left a few more notes; I think there are still some unaddressed comments from earlier too.

AndyAyersMS · 2020-02-18T18:40:30Z

src/coreclr/src/jit/codegenlinear.cpp

Typo 'by aby'

AndyAyersMS · 2020-02-18T18:41:42Z

src/coreclr/src/inc/clrconfigvalues.h

I don't think you need this, the runtime doesn't care...

Ah, yes - thanks.

AndyAyersMS · 2020-02-18T18:43:33Z

src/coreclr/src/jit/lsra.h

Cut and paste issue in comment?

Looks like same just above too, in calleeSaveRegs

Mark EH variables (those that are live in or out of exception regions) only as lvLiveInOutOfHndlr, not necessarily lvDoNotEnregister During register allocation, mark these as write-thru, and mark all defs as write-thru, ensuring that the stack value is always valid. Mark those defs with GTF_SPILLED (this the "reload" flag and is not currently used for pure defs) to indicate that it should be kept in the register. Mark blocks that enter EH regions as having no predecessor, and set the location of all live-in vars to be on the stack. Change genFnPrologCalleeRegArgs to store EH vars also to the stack if they have a register assignment.

…cal register RefPositions during allocation.

CarolEidt · 2020-02-18T19:34:23Z

I think there are still some unaddressed comments from earlier too.

I believe I addressed all of the previous comments, along with the latest; if not, could you point out what's left?

AndyAyersMS · 2020-02-18T19:48:59Z

could you point out what's left?

Looks like just this one.

briansull · 2020-02-18T21:39:15Z

src/coreclr/src/jit/codegencommon.cpp

        {
-#ifdef DEBUG
-            if (VarSetOps::IsMember(this, codeGen->gcInfo.gcVarPtrSetCur, bornVarIndex))
+            if (!varDsc->lvLiveInOutOfHndlr)


Add a comment explaining what/why we are doing here..

briansull · 2020-02-18T21:40:40Z

src/coreclr/src/jit/codegencommon.cpp


 #if defined(TARGET_ARM)
-        if (storeType == TYP_DOUBLE)
+        if ((storeType == TYP_DOUBLE) && !regArgTab[argNum].writeThru)


Add a comment regarding why we special case writeThru here

CarolEidt · 2020-02-19T21:15:23Z

I believe that I've addressed all the PR feedback.

AndyAyersMS

LGTM.

Bruce and I were talking about creating a rolling test where we could enable off by default changes like this so they don't regress while we're working on getting them to be on by default.

CarolEidt added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 5, 2019

CarolEidt force-pushed the EHWriteThru branch from 360d67b to 67c62ea Compare December 9, 2019 04:45

sandreenko reviewed Dec 14, 2019

View reviewed changes

AndyAyersMS reviewed Dec 17, 2019

View reviewed changes

AndyAyersMS reviewed Dec 19, 2019

View reviewed changes

src/coreclr/src/jit/lsrabuild.cpp Outdated

Copy link

Member

AndyAyersMS Dec 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you (perhaps in a comment) explain this part of the change?

AndyAyersMS reviewed Dec 19, 2019

View reviewed changes

CarolEidt force-pushed the EHWriteThru branch from 609b3d2 to 2525c0e Compare January 2, 2020 18:37

CarolEidt force-pushed the EHWriteThru branch 3 times, most recently from cf0b78a to 9cbe9af Compare January 31, 2020 21:22

CarolEidt force-pushed the EHWriteThru branch from 9cbe9af to 0bb9330 Compare February 12, 2020 01:09

lpereira reviewed Feb 12, 2020

View reviewed changes

AndyAyersMS reviewed Feb 18, 2020

View reviewed changes

CarolEidt added 5 commits February 18, 2020 11:21

Throughput tuning - rearrange some fields and short-circuit the physi…

f601889

…cal register RefPositions during allocation.

Disable by default

4ea901d

Clean up target macros, and fix lvMustInit of finally vars

e2153f5

PR Feedback

c8c0f17

CarolEidt force-pushed the EHWriteThru branch from 0bb9330 to c8c0f17 Compare February 18, 2020 19:33

More PR feedback

453f3a5

briansull reviewed Feb 18, 2020

View reviewed changes

AndyAyersMS mentioned this pull request Feb 18, 2020

JIT should suppress zero-extending same-register moves in more scenarios #12402

Open

Additional PR Feedback

2000a85

AndyAyersMS approved these changes Feb 19, 2020

View reviewed changes

CarolEidt merged commit 3be5238 into dotnet:master Feb 19, 2020

BruceForstall mentioned this pull request Feb 20, 2020

Add periodic CI job to test off-by-default code #32576

Closed

CarolEidt deleted the EHWriteThru branch July 16, 2020 16:58

ghost locked as resolved and limited conversation to collaborators Dec 11, 2020

Conversation

CarolEidt commented Dec 5, 2019

Uh oh!

CarolEidt commented Dec 5, 2019

Uh oh!

sandreenko left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CarolEidt commented Dec 17, 2019

Uh oh!

AndyAyersMS left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndyAyersMS Dec 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

AndyAyersMS Dec 17, 2019 •

edited

Loading

AndyAyersMS commented Dec 19, 2019 •

edited

Loading