Do not assume about another half regrec#53412
Merged
kunalspathak merged 1 commit intodotnet:mainfrom May 28, 2021
Merged
Conversation
Contributor
Author
|
Contributor
Author
|
@dotnet/jit-contrib |
BruceForstall
approved these changes
May 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #45135, we started assuming at one place that
RegisterRecordwould always be the even-numbered. (See my question in that PR). However, it seems that recent work of porting SIMDIntrinsicGetItem and SIMDIntrinsicSetItem to HWIntrinsics done in #52288 exposed the problem and prove that the assumption is wrong.The fix is to revert back to pre #45135 change.
Fixes: #53322