CI pipeline monitor label fixes by kg · Pull Request #128501 · dotnet/runtime

kg · 2026-05-22T19:12:26Z

Ensure that when the CI pipeline monitor updater script generates a new issue, it applies blocking-clean-ci-optional
Ensure that during validation we check to make sure all assigned labels are real labels. In a previous run I had generating an issue fail because one of the labels was wrong.

Copilot

Pull request overview

This PR updates the CI pipeline monitor GitHub-issue publishing flow to (1) always apply a default “blocking-clean-ci-optional” label when creating new issues, and (2) add a validation step that checks failure-suggested labels against the live set of labels in the dotnet/runtime repo.

Changes:

Add blocking-clean-ci-optional to gh issue create invocations for newly filed issues.
Add a validator step that fetches repo labels from the GitHub REST API and flags invalid failure labels before update_github.py runs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
.github/skills/ci-pipeline-monitor/scripts/validate_results.py	Adds a new “validate labels exist in dotnet/runtime” check by querying the GitHub labels API.
.github/skills/ci-pipeline-monitor/scripts/update_github.py	Adds `blocking-clean-ci-optional` label when creating a new GitHub issue via `gh`.

kg · 2026-05-22T19:21:28Z

One problem with doing this is that the github REST API has a limit of 60 queries per hour. So running this script more than a few times will hit the rate limit, as I just have and no longer can test it until later on today.

…nt to use for fixes Address copilot feedback

…s will succeed even if we hit a rate limit, as long as one validation run has succeeded

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

 import urllib.request

+LABELS_API_ENDPOINT = "https://api.github.com/repos/dotnet/runtime/labels"
+LABELS_CACHE_FILE = os.path.join(__file__, "..", "cached_labels.json")


            gh_issue_command.append("create")
+            gh_issue_command.append("--label")
+            gh_issue_command.append("blocking-clean-ci-optional")
            creating_new_issue = True


Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

 import urllib.request

+LABELS_API_ENDPOINT = "https://api.github.com/repos/dotnet/runtime/labels"
+LABELS_CACHE_FILE = os.path.join(__file__, "..", "cached_labels.json")


…pplied

…t invokes it using a non-unicode codepage sometimes and causes it to crash

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

 import urllib.request

+LABELS_API_ENDPOINT = "https://api.github.com/repos/dotnet/runtime/labels"
+LABELS_CACHE_FILE = os.path.join(__file__, "..", "cached_labels.json")


… on Apple NativeAOT (refs #130253) (#130328) Workflow artifact: ci-fix Artifact kind: help Linked KBE: #130253 > [!IMPORTANT] > **Help-wanted / needs-review draft.** This is a best-effort candidate fix that I could **not** build-validate in the agent environment (no Apple NativeAOT cross-build is available here). It is a genuine, **non-muting** change — it does not disable, skip, or `[ActiveIssue]` the test. Please validate on the Apple NativeAOT library-test legs before merging. ## Root cause On the Apple **NativeAOT** library-test legs (`iossimulator` / `maccatalyst` `AllSubsets_NativeAOT`, e.g. build [1494308](https://dev.azure.com/dnceng-public/public/_build/results?buildId=1494308)), `System.Diagnostics.Tests.FileVersionInfoTest.FileVersionInfo_CustomManagedAssembly` fails with: ``` System.IO.FileNotFoundException : .../System.Diagnostics.FileVersionInfo.Tests.app/System.Diagnostics.FileVersionInfo.TestAssembly.dll ``` The test opens its companion assembly **by file path** to read PE version metadata — it never loads or executes it (`FileVersionInfoTest.cs:25`): ```csharp VerifyVersionInfo(Path.Combine(Directory.GetCurrentDirectory(), TestAssemblyFileName), ...); // TestAssemblyFileName = "System.Diagnostics.FileVersionInfo.TestAssembly.dll" ``` In the test `.csproj`, for Apple mobile the TestAssembly was included as a **plain `<ProjectReference>`**. Under NativeAOT that assembly is compiled into the native image, so **no loose `.dll` is deployed** next to the app and `Directory.GetCurrentDirectory()/...TestAssembly.dll` does not exist → `FileNotFoundException`. Under Apple **Mono** the managed assembly is still deployed as a file, which is why the test passes there. The existing `[ActiveIssue(".../124344", IsAppleMobile && IsCoreCLR)]` on this test does **not** apply here: `PlatformDetection.IsCoreCLR => IsNotMonoRuntime && IsNotNativeAot` is `false` under NativeAOT, so the test genuinely runs (and fails) on the NativeAOT leg. These NativeAOT library tests on Apple mobile were newly enabled by #125437. ## Candidate change Deploy the TestAssembly as a **Content** data file on the Apple NativeAOT leg (exactly as already done for desktop), while keeping the plain project reference for Apple **Mono**, where the [#46856](#46856) vfs-mapping workaround still applies: - `TargetsAppleMobile && UseNativeAotRuntime` → Content copy (**new**). - `TargetsAppleMobile && !UseNativeAotRuntime` (Mono) → plain reference (unchanged). - Browser and desktop → unchanged. Only the Apple-NativeAOT branch changes; the MSBuild conditions leave Mono Apple, browser, and desktop provably untouched, and never select both `<ProjectReference>` items at once. ## What is unverified (why this is a draft) - I could not run an Apple NativeAOT build here, so I have **not** confirmed the Content `.dll` actually lands at `Directory.GetCurrentDirectory()` inside the NativeAOT `.app` bundle, nor that the AppleAppBuilder NativeAOT library-mode path packages Content identically to Mono. - Reasoning it should work: sibling Content files in this project (`NativeLibrary.dll`, `NativeConsoleApp.exe`) are already deployed and found on Apple, and under NativeAOT there is no managed-assembly vfs mapping for #46856 to collide with — but this needs a CI run to confirm. ## Validation - Build-validated: **No** — Apple NativeAOT cross-build is not available in the agent environment. - Requested: run `System.Diagnostics.FileVersionInfo.Tests` on the `iossimulator` / `maccatalyst` `AllSubsets_NativeAOT` legs and confirm `FileVersionInfo_CustomManagedAssembly` passes with no `identical vfs mappings` packaging error. ## Suggested reviewers / area contacts These tests were enabled on Apple NativeAOT by #125437 — `@kotlarmilos`, could you (or the mobile/NativeAOT folks) confirm the Content asset is bundled at the app's working directory under NativeAOT library mode? Area owners: `@dotnet/area-system-diagnostics`. > [!NOTE] > This PR was generated by an AI/Copilot agent (`ci-failure-fix`) as a best-effort, non-muting candidate fix. Please review carefully before merging. > [!NOTE] > <details> > <summary>🔒 Integrity filter blocked 17 items</summary> > > The following items were blocked because they don't meet the GitHub integrity level. > > - [#128501](#128501) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#104998](#104998) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#104750](#104750) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#97491](#97491) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#76276](#76276) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#78999](#78999) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#76417](#76417) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#69571](#69571) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#62435](#62435) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#61444](#61444) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#35376](#35376) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#193](#193) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#34218](#34218) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#38914](#38914) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - [#44747](#44747) `search_pull_requests`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - #130125 `issue_read`: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". > - ... and 1 more item > > To allow these resources, lower `min-integrity` in your GitHub frontmatter: > > ```yaml > tools: > github: > min-integrity: approved # merged | approved | unapproved | none > ``` > > </details> > Generated by [CI Outer-Loop Failure Fixer](https://github.com/dotnet/runtime/actions/runs/28910596516/agentic_workflow) · ● 9.3M · [◷](https://github.com/search?q=repo%3Adotnet%2Fruntime+%22gh-aw-workflow-id%3A+ci-failure-fix%22&type=pullrequests)   --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com>

kg added 2 commits May 22, 2026 12:11

Validate all labels assigned to failures

05c00a0

Always apply the blocking-clean-ci-optional label to new issues

c7628d7

Copilot AI review requested due to automatic review settings May 22, 2026 19:12

kg added the agentic-workflows label May 22, 2026

Copilot started reviewing on behalf of kg May 22, 2026 19:12 View session

github-actions Bot added the area-skills Agent Skills label May 22, 2026

dotnet-policy-service Bot assigned kg May 22, 2026

Make label validation case insensitive

5745917

Copilot AI reviewed May 22, 2026

View reviewed changes

kg added 2 commits May 22, 2026 12:23

Print list of all valid labels if there is a label error, for the age…

958504a

…nt to use for fixes Address copilot feedback

Maintain a cache of known good labels so that repeated validation run…

51ba238

…s will succeed even if we hit a rate limit, as long as one validation run has succeeded

Copilot AI review requested due to automatic review settings May 22, 2026 19:48

Copilot started reviewing on behalf of kg May 22, 2026 19:48 View session

Don't apply blocking-clean-ci-optional twice

3bca0d6

Copilot AI reviewed May 22, 2026

View reviewed changes

kg added 2 commits May 22, 2026 13:00

Fix cache write

8d738ea

Fix off-by-one

f067342

Copilot AI review requested due to automatic review settings May 22, 2026 20:02

Copilot started reviewing on behalf of kg May 22, 2026 20:02 View session

Copilot AI reviewed May 22, 2026

View reviewed changes

kg added 3 commits May 23, 2026 17:04

Better approach to ensuring the blocking clean ci optional label is a…

72628c2

…pplied

Remove unicode characters from validate_results output because copilo…

7182110

…t invokes it using a non-unicode codepage sometimes and causes it to crash

Checkpoint

e24404f

Copilot AI review requested due to automatic review settings May 26, 2026 16:57

Copilot started reviewing on behalf of kg May 26, 2026 16:57 View session

Fix type error

6a0a69a

Copilot AI reviewed May 26, 2026

View reviewed changes

Address PR feedback from copilot

221e011

github-actions Bot mentioned this pull request Jun 11, 2026

[ci-scan-feedback] KPI Tracker #128742

Open

Copilot AI mentioned this pull request Jun 19, 2026

[ci-scan-feedback] Add pipeline-category gate to fixer prompt #129611

Merged

Copilot AI mentioned this pull request Jul 14, 2026

Guard CI fixer against no-op test rooting changes #130668

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CI pipeline monitor label fixes#128501

CI pipeline monitor label fixes#128501
kg wants to merge 13 commits into
dotnet:mainfrom
kg:ci-pipeline-monitor-label-fixes

kg commented May 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kg commented May 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

kg commented May 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kg commented May 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants