Guard CI fixer against no-op test rooting changes#130668
Conversation
|
Azure Pipelines: 15 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: kotlarmilos <11523312+kotlarmilos@users.noreply.github.com>
|
/ci-eval |
|
/ci-eval Note This retry was posted by GitHub Copilot at the user's request after the PAT pool selected an invalid token. |
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
|
/ci-feedback eval Note This command was posted by GitHub Copilot at the user's request to complete the feedback eval cancelled by a concurrent policy-service comment. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c88c0b65-971b-4cc4-9674-e6d83c3b8ee3
There was a problem hiding this comment.
Pull request overview
Updates the CI outer-loop fixer workflow guidance to prevent proposing ineffective “rooting” changes for NativeAOT/runtime-missing failures when test assemblies are already effectively rooted by the harness.
Changes:
- Refines the Mobile (ios/tvos/maccatalyst/android/wasm/wasi) policy row to refer readers to the Step 5.2 “already-rooted” guidance before proposing roots.
- Adds a new Step 5.2 caution that instructs the fixer to check for existing roots and avoid no-op rooting proposals for already-rooted test assemblies, otherwise routing to a concrete product-side cause or a loop-in comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci-failure-fix.md | Adds/centralizes guidance to guard the fixer against proposing redundant NativeAOT trimming/rooting changes for already-rooted test assemblies. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 14 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
/ci-eval Note This eval retry was triggered by GitHub Copilot at the user request and uses the workflow from the latest |
|
Note AI/Copilot-generated eval report (Vally), triggered by a maintainer eval command. ci-failure-scan✅ passed detailsEval Results
Dynamic gate for the CI failure scanner's safe-output, run with the maintainer /ci-scan eval command. It runs the scanner against a live outer-loop failure it discovers itself, then checks the emitted Known Build Error against the static KBE format and that it actually grounded the KBE in a real failing build.
ci-failure-fix❌ failed detailsEval Results
Dynamic behavior gate for the CI failure fixer's safe-output, run with the maintainer /ci-fix eval command. It points the fixer at a real open Known Build Error it discovers itself and checks that it either produced a fix PR or engaged owners, and never muted the failing test.
[1] Failed grader(s):
ci-failure-scan-feedback❌ failed detailsEval Results
Dynamic constructiveness gate for the CI feedback meta workflow's safe-output, run with the maintainer /ci-feedback eval command. The agent scans real recent scanner issues and fixer PRs itself, then must turn a real signal into constructive, grounded feedback.
[1] Failed grader(s):
|
Runtime-missing failures can prompt ineffective rooting changes when the harness or project already roots the test assembly, regardless of runtime mode.
DynamicDependency, descriptor,TrimmerRootAssembly, or app-bundle changes.Note
This PR description was generated with GitHub Copilot.