[release/9.0] [browser] Fix processing of satellite assemblies from referenced assembly during publish#107398
Merged
jeffschwMSFT merged 12 commits intorelease/9.0from Sep 12, 2024
Merged
Conversation
…ectReference) where ResolvedFrom contains {RawFileName}
…blish because they can be resource assemblies from References
…oes through the same path and are not discovered by nested publish
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
ilonatommy
approved these changes
Sep 6, 2024
Member
|
/ba-g failure is known and tracked |
lewing
approved these changes
Sep 10, 2024
Member
|
/ba-g failures are known and tracked |
3 tasks
jeffschwMSFT
approved these changes
Sep 12, 2024
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can merge when ready
2 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #106696 to release/9.0
/cc @maraf
Customer Impact
This PR fixes publishing satellite assemblies in (Blazor) WebAssembly apps in two scenarios
<Reference Include="A.dll" />with satellite assemblies,<ProjectReference Include="A.csproj" />with satellite assemblies.Regression
The first scenario (reference) was reported by customer in #105937. After investigation it turned out it is not a regression, and this scenario was never working in Blazor WebAssembly apps.
The second scenario (project reference) was discovered during investigation and is in fact regression from #90436. It wasn't well covered with tests, as it manifests only when wasm-tools workload is installed and publish is running for project with a project reference with satellite assemblies.
Testing
The PR adds automated tests for both reference and project reference with satellite assemblies and doing publish with workload installed.
Risk
Low. Affected scenarios are covered with automatic tests. One potential unknown is that the PR enables satellite assembly probing in nested build, which may result in slower publish, but the underlaying MSBuild task (ResolveAssemblyReference) searches only top-level directory where each reference lives, which should not be a significant IO overhead.