[browser] Fix processing of satellite assemblies from referenced assembly during publish#106696
Merged
maraf merged 11 commits intodotnet:mainfrom Sep 5, 2024
Merged
Conversation
…ectReference) where ResolvedFrom contains {RawFileName}
…blish because they can be resource assemblies from References
maraf
commented
Aug 20, 2024
...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets
Outdated
Show resolved
Hide resolved
ilonatommy
requested changes
Aug 21, 2024
src/mono/wasm/testassets/WasmBasicTestApp/ResourceLibrary/ResourceAccessor.cs
Outdated
Show resolved
Hide resolved
...nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets
Outdated
Show resolved
Hide resolved
ilonatommy
approved these changes
Aug 21, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…oes through the same path and are not discovered by nested publish
Open
3 tasks
This was referenced Aug 29, 2024
Member
Author
|
This AOT failure didn't find app assembly AOT module. Based on output it seems it didn't run main (out it didn't provide console writes), but return of 42 from nodejs is expected https://helix.dot.net/api/2019-06-17/jobs/61a94806-100b-49f2-b546-f69dd33afd15/workitems/Workloads-NoWebcil-ST-Wasm.Build.Tests.WasmTemplateTests/console |
Member
Author
In console app published trimmed, it copies all satellite assemblies, even for linked out libraries |
Member
Author
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10720328255 |
4 tasks
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
…mbly during publish (dotnet#106696)
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
…mbly during publish (dotnet#106696)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RelatedAssetto satellite assemblies from<Reference />.ResolveAssemblyReferencesFindRelatedSatellites=trueto nested publish to enable searching for satellite assemblies.<ProjectReference />&<Reference />.Context
ResolveAssemblyReferencesFindRelatedSatellitesis set to false by defaultFixes #105937